Skip to content

fix(deps): update dependency strip-json-comments to v4 #2301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 19, 2021

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
strip-json-comments 3.1.1 -> 4.0.0 age adoption passing confidence

Release Notes

sindresorhus/strip-json-comments

v4.0.0

Compare Source

Breaking

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/strip-json-comments-4.x branch from c07a460 to d8faa85 Compare November 26, 2021 16:33
@renovate renovate bot force-pushed the renovate/strip-json-comments-4.x branch from d8faa85 to dd30b50 Compare February 7, 2022 14:45
@renovate renovate bot force-pushed the renovate/strip-json-comments-4.x branch from dd30b50 to 65a3d36 Compare March 24, 2022 20:29
@renovate renovate bot force-pushed the renovate/strip-json-comments-4.x branch from 65a3d36 to 14b9e20 Compare April 30, 2022 03:44
@renovate renovate bot force-pushed the renovate/strip-json-comments-4.x branch 2 times, most recently from 7081ab0 to 4340fb7 Compare May 24, 2022 11:38
@rpl rpl force-pushed the renovate/strip-json-comments-4.x branch from 4340fb7 to e985a6e Compare May 24, 2022 11:58
@rpl rpl requested review from willdurand and removed request for willdurand May 24, 2022 11:59
@rpl
Copy link
Member

rpl commented May 24, 2022

The last major version is an ESM modules, in theory we could import it dynamically but the current webpack config is rewriting the dynamic imports into require calls and so just changing the static imports into dynamic imports isn't enough.

@renovate renovate bot force-pushed the renovate/strip-json-comments-4.x branch from e985a6e to d51db77 Compare May 24, 2022 12:27
@renovate renovate bot force-pushed the renovate/strip-json-comments-4.x branch from d51db77 to a5386b3 Compare June 3, 2022 18:47
@willdurand
Copy link
Member

😎

@renovate renovate bot force-pushed the renovate/strip-json-comments-4.x branch from a5386b3 to 63273b4 Compare June 3, 2022 19:01
@rpl
Copy link
Member

rpl commented Jun 3, 2022

sunglasses

"Once upon the time there was a pull request marked as state: do not merge... then finally... easy like pressing a button, it is now merged. The End" 🤣

@rpl rpl merged commit f3729b6 into master Jun 3, 2022
@rpl rpl deleted the renovate/strip-json-comments-4.x branch June 3, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants