Skip to content

fix: many typos #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 30, 2025
Merged

fix: many typos #453

merged 3 commits into from
Mar 30, 2025

Conversation

mimikun
Copy link
Contributor

@mimikun mimikun commented Mar 29, 2025

Fix some typos.
Since this involves breaking changes such as changing the option name,
I think it would be better to leave the mistyped option name and mark it as deprecated in LuaLS.

e.g.

lua/haskell-tools/config/internal.lua

-- ....
              exception = true,
             },
           },
           ---@deprecated -- add it
           excplicitFixity = { globalOn = true },
           explicitFixity = { globalOn = true },
           gadt = { globalOn = true },
           ['ghcide-code-actions-bindings'] = { globalOn = true },
           ['ghcide-code-actions-fill-holes'] = { globalOn = true },
--- ....

e6e38c0

Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.

@mrcjkb mrcjkb enabled auto-merge (squash) March 30, 2025 00:22
@mrcjkb mrcjkb disabled auto-merge March 30, 2025 06:52
Copy link
Owner

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

No need for the deprecation, as that typo is in the default hls config, not the user facing config.

@mrcjkb mrcjkb merged commit b6587ae into mrcjkb:master Mar 30, 2025
5 checks passed
mrcjkb added a commit that referenced this pull request Mar 30, 2025
🤖 I have created a release *beep* *boop*
---


##
[4.4.3](v4.4.2...v4.4.3)
(2025-03-30)


### Bug Fixes

* typos in lua/vim docs
([#453](#453))
([b6587ae](b6587ae))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants