run and fix eslint issues in the codebase

Author: Brijesh Bittu

.github/workflows/scripts/prs/checkTargetBranchLabel.js

@@ -1,6 +1,6 @@
 // @ts-check
 const vBranchRegex = /^v\d{1,3}\.x$/;
-const transferLabels = ['cherry-pick'];
+// const transferLabels = ['cherry-pick'];
 
 /**
  * @param {Object} params

.github/workflows/scripts/prs/checkTypeLabel.js

@@ -1,12 +1,10 @@
 // @ts-check
 const createEnumerationFromArray = (stringArray) =>
   stringArray.length > 1
-    ? stringArray
+    ? `${stringArray
         .slice(0, -1)
         .map((s) => `\`${s}\``)
-        .join(', ') +
-      ' or ' +
-      `\`${stringArray.slice(-1)}\``
+        .join(', ')} or \`${stringArray.slice(-1)}\``
     : stringArray.map((s) => `\`${s}\``).join('');
 
 const typeLabels = [
@@ -15,7 +13,7 @@ const typeLabels = [
   'enhancement',
   'new feature',
   // Those are not "Types" labels, they are "Kind of work" labels, but we don't want to have to handle the overhead of
-  // setting “Types” labels with them.
+  // setting "Types" labels with them.
   'release',
   'dependencies',
 ];
@@ -65,12 +63,13 @@ const createCommentHandler =
         return;
       }
 
-      return await github.rest.issues.updateComment({
+      await github.rest.issues.updateComment({
         owner,
         repo,
         comment_id: commentFound.id,
         body: commentLines.join('\n\n'),
       });
+      return;
     }
 
     // only create a new comment if it's not the success comment
@@ -81,7 +80,7 @@ const createCommentHandler =
     }
 
     core.info(`>>> Creating explanatory comment on PR`);
-    return await github.rest.issues.createComment({
+    await github.rest.issues.createComment({
       owner,
       repo,
       issue_number: pullNumber,

apps/code-infra-dashboard/functions/circle-ci-artifacts.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/prefer-default-export */
 import type { Handler } from '@netlify/functions';
 import zlib from 'zlib';
 import util from 'util';

apps/tools-public/toolpad/resources/bundleSizeQueries.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/prefer-default-export */
 import axios from 'axios';
 
 function getMainBundleLabel(bundleId: string): string {

apps/tools-public/toolpad/resources/queryAbout.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/prefer-default-export */
 function flip(data) {
   return Object.fromEntries(Object.entries(data).map(([key, value]) => [value, key]));
 }

apps/tools-public/toolpad/resources/queryGitHubSearchAPI.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/prefer-default-export */
 import { rawRequest } from 'graphql-request';
 
 export async function queryGitHubSearchAPI(queryInput = '', type = 'ISSUE') {

apps/tools-public/toolpad/resources/queryJoyUIMonthlyDownloads.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/prefer-default-export */
 import { formatDatePart, getDateString, getMonthKey } from './queryHeadlessLibrariesDownloads';
 
 const prepareData = (inData) => {

apps/tools-public/toolpad/resources/queryLabelsActivity.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/prefer-default-export */
 import { request } from 'graphql-request';
 
 interface LabelTimelineItem {

apps/tools-public/toolpad/resources/queryPRs.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/prefer-default-export */
 import { request } from 'graphql-request';
 
 interface PullRequest {

apps/tools-public/toolpad/resources/queryPRswithoutReviewer.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/prefer-default-export */
 import { request } from 'graphql-request';
 
 export async function queryPRswithoutReviewer() {

apps/tools-public/toolpad/resources/updateMuiPaidSupport.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/prefer-default-export */
 import dayjs from 'dayjs';
 import { sheets } from '@googleapis/sheets';
 import { JWT } from 'google-auth-library';

eslint.config.mjs

@@ -3,7 +3,6 @@ import { defineConfig } from 'eslint/config';
 import * as path from 'node:path';
 import baseConfig from '@mui/configs/eslint';
 import testConfig from '@mui/configs/eslint/test';
-import muiPlugin from '@mui/configs/eslint/material-ui';
 import { fileURLToPath } from 'url';
 
 const filename = fileURLToPath(import.meta.url);
@@ -31,9 +30,6 @@ export default defineConfig(
       'jsx-a11y/no-autofocus': 'off',
       'import-x/extensions': 'off',
     },
-    plugins: {
-      'material-ui': muiPlugin,
-    },
   },
   {
     files: [

packages/babel-plugin-minify-errors/__fixtures__/.eslintrc.js renamed to packages/babel-plugin-minify-errors/__fixtures__/eslint.config.mjs

@@ -1,4 +1,4 @@
-module.exports = {
+export default {
   rules: {
     // keeps test simple
     'no-unreachable': 'off',

packages/bundle-size-checker/.eslintrc.cjs renamed to packages/bundle-size-checker/eslint.config.mjs

@@ -1,8 +1,8 @@
-module.exports = {
+export default {
   rules: {
-    'import/prefer-default-export': 'off',
+    'import-x/prefer-default-export': 'off',
     // Allow .js file extensions in import statements for ESM compatibility
-    'import/extensions': [
+    'import-x/extensions': [
       'error',
       'ignorePackages',
       {

packages/bundle-size-checker/src/cli.js

@@ -2,9 +2,9 @@
 
 import path from 'path';
 import os from 'os';
-import fse from 'fs-extra';
+import * as fse from 'fs-extra';
 import yargs from 'yargs';
-import Piscina from 'piscina';
+import { Piscina } from 'piscina';
 import micromatch from 'micromatch';
 import { loadConfig } from './configLoader.js';
 import { uploadSnapshot } from './uploadSnapshot.js';