[code-infra] Infra package followup #344

Addresses some of the comments from the previous PR #344

Author: Brijesh Bittu

.github/workflows/scripts/prs/checkTargetBranchLabel.js

@@ -1,6 +1,5 @@
 // @ts-check
 const vBranchRegex = /^v\d{1,3}\.x$/;
-// const transferLabels = ['cherry-pick'];
 
 /**
  * @param {Object} params

packages/code-infra/package.json

@@ -6,7 +6,7 @@
   "repository": {
     "type": "git",
     "url": "https://github.com/mui/mui-public.git",
-    "directory": "packages/mui-internal-code-infra"
+    "directory": "packages/code-infra"
   },
   "sideEffects": false,
   "exports": {
@@ -45,14 +45,6 @@
     "eslint": "^9.0.0",
     "prettier": "^3.0.0"
   },
-  "peerDependenciesMeta": {
-    "eslint": {
-      "optional": true
-    },
-    "prettier": {
-      "optional": true
-    }
-  },
   "devDependencies": {
     "@next/eslint-plugin-next": "^15.3.3",
     "@types/eslint-plugin-jsx-a11y": "^6.10.0",

packages/code-infra/src/eslint/testConfig.mjs

@@ -38,13 +38,16 @@ export const baseSpecRules = {
 };
 
 /**
+ * @param {Object} [options]
+ * @param {boolean} [options.useMocha]
  * @returns {import('eslint').Linter.Config[]}
  */
-export function createTestConfig() {
+export function createTestConfig(options = {}) {
+  const { useMocha = true } = options;
   return /** @type {import('eslint').Linter.Config[]} */ (
     tseslint.config(
       // @ts-expect-error The types don't make sense here.
-      mochaPlugin.configs.recommended,
+      useMocha ? mochaPlugin.configs.recommended : null,
       testingLibrary.configs['flat/dom'],
       testingLibrary.configs['flat/react'],
       {
@@ -59,23 +62,6 @@ export function createTestConfig() {
           // does not work with wildcard imports. Mistakes will throw at runtime anyway
           'import/named': 'off',
           'material-ui/disallow-active-element-as-key-event-target': 'error',
-          'mocha/consistent-spacing-between-blocks': 'off',
-
-          // upgraded level from recommended
-          'mocha/no-pending-tests': 'error',
-
-          // no rationale provided in /recommended
-          'mocha/no-mocha-arrows': 'off',
-          // definitely a useful rule but too many false positives
-          // due to `describeConformance`
-          // "If you're using dynamically generated tests, you should disable this rule.""
-          'mocha/no-setup-in-describe': 'off',
-          // `beforeEach` for a single case is optimized for change
-          // when we add a test we don't have to refactor the existing
-          // test to `beforeEach`.
-          // `beforeEach`+`afterEach` also means that the `beforeEach`
-          // is cleaned up in `afterEach` if the test causes a crash
-          'mocha/no-hooks-for-single-case': 'off',
 
           // disable eslint-plugin-jsx-a11y
           // tests are not driven by assistive technology
@@ -97,6 +83,27 @@ export function createTestConfig() {
           // that they don't need type-checking
           'react/prop-types': 'off',
           'react/no-unused-prop-types': 'off',
+          ...(useMocha
+            ? {
+                'mocha/consistent-spacing-between-blocks': 'off',
+
+                // upgraded level from recommended
+                'mocha/no-pending-tests': 'error',
+
+                // no rationale provided in /recommended
+                'mocha/no-mocha-arrows': 'off',
+                // definitely a useful rule but too many false positives
+                // due to `describeConformance`
+                // "If you're using dynamically generated tests, you should disable this rule.""
+                'mocha/no-setup-in-describe': 'off',
+                // `beforeEach` for a single case is optimized for change
+                // when we add a test we don't have to refactor the existing
+                // test to `beforeEach`.
+                // `beforeEach`+`afterEach` also means that the `beforeEach`
+                // is cleaned up in `afterEach` if the test causes a crash
+                'mocha/no-hooks-for-single-case': 'off',
+              }
+            : {}),
         },
       },
     )