[charts] Remove unused generics from bar charts (#20642)

Author: bernardobelchior

packages/x-charts/src/BarChart/BarLabel/BarLabel.types.ts

@@ -13,7 +13,7 @@ export interface BarLabelOwnerState {
   classes?: Partial<BarLabelClasses>;
 }
 
-export type BarItem<V extends BarValueType | null = BarValueType | null> = {
+export type BarItem = {
   /**
    * The series id of the bar.
    */
@@ -25,7 +25,7 @@ export type BarItem<V extends BarValueType | null = BarValueType | null> = {
   /**
    * The value of the data point.
    */
-  value: V;
+  value: BarValueType | null;
 };
 
 export type BarLabelContext = {
@@ -43,7 +43,7 @@ export type BarLabelContext = {
   };
 };
 
-export type BarLabelFunction<V extends BarValueType | null = BarValueType | null> = (
-  item: BarItem<V>,
+export type BarLabelFunction = (
+  item: BarItem,
   context: BarLabelContext,
 ) => string | null | undefined;

packages/x-charts/src/BarChart/BarLabel/BarLabelItem.tsx

@@ -79,9 +79,7 @@ export type BarLabelItemProps<V extends BarValueType | null> = Omit<
      * @param {BarLabelContext} context data about the bar.
      * @returns {string} The formatted label.
      */
-    barLabel?:
-      | 'value'
-      | ((item: BarItem<V>, context: BarLabelContext) => string | null | undefined);
+    barLabel?: 'value' | ((item: BarItem, context: BarLabelContext) => string | null | undefined);
     /**
      * The placement of the bar label.
      * It controls whether the label is rendered in the center or outside the bar.

packages/x-charts/src/BarChart/BarLabel/BarLabelPlot.tsx

@@ -5,36 +5,34 @@ import type { SeriesId } from '../../models/seriesType/common';
 import { type BarSeriesType, type BarValueType } from '../../models/seriesType/bar';
 import { type BarLabelFunction } from './BarLabel.types';
 
-interface BarLabelPlotProps<V extends BarValueType | null = BarValueType | null> {
-  processedSeries: ProcessedBarLabelSeriesData<V>;
+interface BarLabelPlotProps {
+  processedSeries: ProcessedBarLabelSeriesData;
   className: string;
   skipAnimation?: boolean;
-  barLabel?: BarLabelItemProps<V | null>['barLabel'];
+  barLabel?: BarLabelItemProps<BarValueType | null>['barLabel'];
 }
 
-export interface ProcessedBarLabelSeriesData<V extends BarValueType | null> {
+export interface ProcessedBarLabelSeriesData {
   seriesId: SeriesId;
-  data: ProcessedBarLabelData<V>[];
-  barLabel?: 'value' | BarLabelFunction<V>;
+  data: ProcessedBarLabelData[];
+  barLabel?: 'value' | BarLabelFunction;
   barLabelPlacement?: BarSeriesType['barLabelPlacement'];
   layout?: 'vertical' | 'horizontal';
   xOrigin: number;
   yOrigin: number;
 }
 
-export interface ProcessedBarLabelData<V extends BarValueType | null> extends AnimationData {
+export interface ProcessedBarLabelData extends AnimationData {
   seriesId: SeriesId;
   dataIndex: number;
   color: string;
-  value: V;
+  value: BarValueType | null;
 }
 
 /**
  * @ignore - internal component.
  */
-function BarLabelPlot<V extends BarValueType | null = BarValueType | null>(
-  props: BarLabelPlotProps<V>,
-) {
+function BarLabelPlot(props: BarLabelPlotProps) {
   const { processedSeries, className, skipAnimation, ...other } = props;
   const { seriesId, data, layout, xOrigin, yOrigin } = processedSeries;
 

packages/x-charts/src/BarChart/BarLabel/getBarLabel.ts

@@ -2,9 +2,9 @@ import { type SeriesId } from '../../models/seriesType/common';
 import { type BarLabelFunction } from './BarLabel.types';
 import { type BarValueType } from '../../models/seriesType/bar';
 
-export function getBarLabel<V extends BarValueType | null = BarValueType | null>(options: {
-  barLabel: 'value' | BarLabelFunction<V>;
-  value: V;
+export function getBarLabel(options: {
+  barLabel: 'value' | BarLabelFunction;
+  value: BarValueType | null;
   dataIndex: number;
   seriesId: SeriesId;
   height: number;

packages/x-charts/src/BarChart/BarPlot.tsx

@@ -4,7 +4,7 @@ import PropTypes from 'prop-types';
 import { styled } from '@mui/material/styles';
 import { barElementClasses } from './barElementClasses';
 import { BarElement, type BarElementSlotProps, type BarElementSlots } from './BarElement';
-import { type BarItemIdentifier, type BarValueType } from '../models';
+import { type BarItemIdentifier } from '../models';
 import { useDrawingArea, useXAxes, useYAxes } from '../hooks';
 import { BarClipPath } from './BarClipPath';
 import { type BarLabelSlotProps, type BarLabelSlots } from './BarLabel/BarLabelItem';
@@ -160,7 +160,7 @@ function BarPlot(props: BarPlotProps) {
         );
       })}
       {completedData.map((processedSeries) => (
-        <BarLabelPlot<BarValueType | null>
+        <BarLabelPlot
           key={processedSeries.seriesId}
           className={classes.seriesLabels}
           processedSeries={processedSeries}

packages/x-charts/src/BarChart/seriesConfig/bar/getSeriesWithDefaultValues.ts

@@ -1,7 +1,7 @@
 import { type AllSeriesType } from '../../../models/seriesType';
 
-export function getSeriesWithDefaultValues<T extends 'bar'>(
-  seriesData: AllSeriesType<T>,
+export function getSeriesWithDefaultValues(
+  seriesData: AllSeriesType<'bar'>,
   seriesIndex: number,
   colors: readonly string[],
 ) {