Work

Author: flaviendelangle

packages/x-date-pickers/src/DateField/useDateField.ts

@@ -12,7 +12,10 @@ export const useDateField = <
   props: TAllProps,
 ) => {
   const valueManager = React.useMemo(
-    () => getDateValueManager(props.enableAccessibleFieldDOMStructure),
+    () =>
+      getDateValueManager({
+        enableAccessibleFieldDOMStructure: props.enableAccessibleFieldDOMStructure,
+      }),
     [props.enableAccessibleFieldDOMStructure],
   );
 

packages/x-date-pickers/src/DateTimeField/useDateTimeField.ts

@@ -12,7 +12,10 @@ export const useDateTimeField = <
   props: TAllProps,
 ) => {
   const valueManager = React.useMemo(
-    () => getDateTimeValueManager(props.enableAccessibleFieldDOMStructure),
+    () =>
+      getDateTimeValueManager({
+        enableAccessibleFieldDOMStructure: props.enableAccessibleFieldDOMStructure,
+      }),
     [props.enableAccessibleFieldDOMStructure],
   );
 

packages/x-date-pickers/src/TimeField/useTimeField.ts

@@ -12,7 +12,10 @@ export const useTimeField = <
   props: TAllProps,
 ) => {
   const valueManager = React.useMemo(
-    () => getTimeValueManager(props.enableAccessibleFieldDOMStructure),
+    () =>
+      getTimeValueManager({
+        enableAccessibleFieldDOMStructure: props.enableAccessibleFieldDOMStructure,
+      }),
     [props.enableAccessibleFieldDOMStructure],
   );
 

packages/x-date-pickers/src/models/valueManager.ts

@@ -22,9 +22,15 @@ export interface PickerValueManagerV8<
     TError
   >,
 > {
-  // The v7 value manager object.
-  // This will be inlined inside the main `PickerValueManagerV8` object once every object using it is compatible with the new API.
+  /**
+   * Object containing basic methods to interact with the value of the picker or field.
+   * The properties of this object will be inlined inside the main `PickerValueManagerV8` object once every object using it is compatible with the new API.
+   */
   legacyValueManager: PickerValueManager<TIsRange, TError>;
+  /**
+   * Object containing all the necessary methods to interact with the value of the field.
+   * The properties of this object will be inlined inside the main `PickerValueManagerV8` object once every object using it is compatible with the new API.
+   */
   fieldValueManager: FieldValueManager<TIsRange>;
   /**
    * Checks if a value is valid and returns an error code otherwise.
@@ -45,6 +51,10 @@ export interface PickerValueManagerV8<
    * The type of the value (e.g. 'date', 'date-time', 'time').
    */
   valueType: FieldValueType;
+  /**
+   * `true` if the field is using the accessible DOM structure.
+   * `false` if the field is using the non-accessible legacy DOM structure (which will be deprecated and removed in the future).
+   */
   enableAccessibleFieldDOMStructure: TEnableAccessibleFieldDOMStructure;
 }
 
@@ -55,10 +65,8 @@ interface ApplyDefaultsToFieldInternalPropsParameters<TFieldInternalProps extend
 
 export type PickerAnyValueManagerV8 = PickerValueManagerV8<any, any, any, any, any>;
 
-export type PickerAnyAccessibleValueManagerV8 = PickerValueManagerV8<any, true, any, any, any>;
-
 /**
- * Infer all the usual generic in the picker packages from a `PickerValueManager` interface.
+ * Infer all the usual generic in the picker packages from a `PickerValueManagerV8` interface.
  */
 export type PickerManagerProperties<TManager extends PickerAnyValueManagerV8> =
   TManager extends PickerValueManagerV8<

packages/x-date-pickers/src/valueManagers/getDateTimeValueManager.ts

@@ -37,6 +37,13 @@ export interface DateTimeFieldInternalPropsWithDefaults<
 > extends UseFieldInternalProps<false, TEnableAccessibleFieldDOMStructure, DateTimeValidationError>,
     ValidateDateTimeProps {}
 
+type DateTimeFieldPropsToDefault =
+  | 'format'
+  // minTime and maxTime can still be undefined after applying defaults.
+  | 'minTime'
+  | 'maxTime'
+  | ValidateDateTimePropsToDefault;
+
 export const getDateTimeFieldInternalPropsDefaults = <
   TEnableAccessibleFieldDOMStructure extends boolean,
 >({
@@ -46,22 +53,18 @@ export const getDateTimeFieldInternalPropsDefaults = <
 }: Pick<MuiPickersAdapterContextValue, 'defaultDates' | 'utils'> & {
   internalProps: Pick<
     DateTimeFieldInternalProps<TEnableAccessibleFieldDOMStructure>,
-    | 'format'
-    | 'ampm'
-    | 'minDateTime'
-    | 'maxDateTime'
-    | 'minTime'
-    | 'maxTime'
-    | ValidateDateTimePropsToDefault
+    DateTimeFieldPropsToDefault | 'minDateTime' | 'maxDateTime' | 'ampm'
   >;
-}) => {
+}): Pick<
+  DateTimeFieldInternalPropsWithDefaults<TEnableAccessibleFieldDOMStructure>,
+  DateTimeFieldPropsToDefault | 'disableIgnoringDatePartForTimeValidation'
+> => {
   const ampm = internalProps.ampm ?? utils.is12HourCycleInCurrentLocale();
   const defaultFormat = ampm
     ? utils.formats.keyboardDateTime12h
     : utils.formats.keyboardDateTime24h;
 
   return {
-    ampm,
     disablePast: internalProps.disablePast ?? false,
     disableFuture: internalProps.disableFuture ?? false,
     format: internalProps.format ?? defaultFormat,
@@ -83,9 +86,11 @@ export const getDateTimeFieldInternalPropsDefaults = <
   };
 };
 
-export const getDateTimeValueManager = <TEnableAccessibleFieldDOMStructure extends boolean = false>(
-  enableAccessibleFieldDOMStructure: TEnableAccessibleFieldDOMStructure = false as TEnableAccessibleFieldDOMStructure,
-): DateTimeValueManager<TEnableAccessibleFieldDOMStructure> => ({
+export const getDateTimeValueManager = <TEnableAccessibleFieldDOMStructure extends boolean = true>({
+  enableAccessibleFieldDOMStructure = true as TEnableAccessibleFieldDOMStructure,
+}: {
+  enableAccessibleFieldDOMStructure: TEnableAccessibleFieldDOMStructure | undefined;
+}): DateTimeValueManager<TEnableAccessibleFieldDOMStructure> => ({
   legacyValueManager: singleItemValueManager,
   fieldValueManager: singleItemFieldValueManager,
   validator: validateDateTime,

packages/x-date-pickers/src/valueManagers/getDateValueManager.ts

@@ -35,6 +35,8 @@ export interface DateFieldInternalPropsWithDefaults<
 > extends UseFieldInternalProps<false, TEnableAccessibleFieldDOMStructure, DateValidationError>,
     ValidateDateProps {}
 
+type DateFieldPropsToDefault = 'format' | ValidateDatePropsToDefault;
+
 export const getDateFieldInternalPropsDefaults = <
   TEnableAccessibleFieldDOMStructure extends boolean,
 >({
@@ -44,19 +46,24 @@ export const getDateFieldInternalPropsDefaults = <
 }: Pick<MuiPickersAdapterContextValue, 'defaultDates' | 'utils'> & {
   internalProps: Pick<
     DateFieldInternalProps<TEnableAccessibleFieldDOMStructure>,
-    'format' | ValidateDatePropsToDefault
+    DateFieldPropsToDefault
   >;
-}) => ({
+}): Pick<
+  DateFieldInternalPropsWithDefaults<TEnableAccessibleFieldDOMStructure>,
+  DateFieldPropsToDefault
+> => ({
+  format: internalProps.format ?? utils.formats.keyboardDate,
   disablePast: internalProps.disablePast ?? false,
   disableFuture: internalProps.disableFuture ?? false,
-  format: internalProps.format ?? utils.formats.keyboardDate,
   minDate: applyDefaultDate(utils, internalProps.minDate, defaultDates.minDate),
   maxDate: applyDefaultDate(utils, internalProps.maxDate, defaultDates.maxDate),
 });
 
-export const getDateValueManager = <TEnableAccessibleFieldDOMStructure extends boolean = false>(
-  enableAccessibleFieldDOMStructure: TEnableAccessibleFieldDOMStructure = false as TEnableAccessibleFieldDOMStructure,
-): DateValueManager<TEnableAccessibleFieldDOMStructure> => ({
+export const getDateValueManager = <TEnableAccessibleFieldDOMStructure extends boolean = true>({
+  enableAccessibleFieldDOMStructure = true as TEnableAccessibleFieldDOMStructure,
+}: {
+  enableAccessibleFieldDOMStructure: TEnableAccessibleFieldDOMStructure | undefined;
+}): DateValueManager<TEnableAccessibleFieldDOMStructure> => ({
   legacyValueManager: singleItemValueManager,
   fieldValueManager: singleItemFieldValueManager,
   validator: validateDate,

packages/x-date-pickers/src/valueManagers/getTimeValueManager.ts

@@ -36,6 +36,8 @@ export interface TimeFieldInternalPropsWithDefaults<
 > extends UseFieldInternalProps<false, TEnableAccessibleFieldDOMStructure, TimeValidationError>,
     ValidateTimeProps {}
 
+type TimeFieldPropsToDefault = 'format' | ValidateTimePropsToDefault;
+
 export const getTimeFieldInternalPropsDefaults = <
   TEnableAccessibleFieldDOMStructure extends boolean,
 >({
@@ -44,23 +46,27 @@ export const getTimeFieldInternalPropsDefaults = <
 }: Pick<MuiPickersAdapterContextValue, 'utils'> & {
   internalProps: Pick<
     TimeFieldInternalProps<TEnableAccessibleFieldDOMStructure>,
-    'format' | 'ampm' | ValidateTimePropsToDefault
+    TimeFieldPropsToDefault | 'ampm'
   >;
-}) => {
+}): Pick<
+  TimeFieldInternalPropsWithDefaults<TEnableAccessibleFieldDOMStructure>,
+  TimeFieldPropsToDefault
+> => {
   const ampm = internalProps.ampm ?? utils.is12HourCycleInCurrentLocale();
   const defaultFormat = ampm ? utils.formats.fullTime12h : utils.formats.fullTime24h;
 
   return {
-    ampm,
     disablePast: internalProps.disablePast ?? false,
     disableFuture: internalProps.disableFuture ?? false,
     format: internalProps.format ?? defaultFormat,
   };
 };
 
-export const getTimeValueManager = <TEnableAccessibleFieldDOMStructure extends boolean = false>(
-  enableAccessibleFieldDOMStructure: TEnableAccessibleFieldDOMStructure = false as TEnableAccessibleFieldDOMStructure,
-): TimeValueManager<TEnableAccessibleFieldDOMStructure> => ({
+export const getTimeValueManager = <TEnableAccessibleFieldDOMStructure extends boolean = true>({
+  enableAccessibleFieldDOMStructure = true as TEnableAccessibleFieldDOMStructure,
+}: {
+  enableAccessibleFieldDOMStructure: TEnableAccessibleFieldDOMStructure | undefined;
+}): TimeValueManager<TEnableAccessibleFieldDOMStructure> => ({
   legacyValueManager: singleItemValueManager,
   fieldValueManager: singleItemFieldValueManager,
   validator: validateTime,