Cleanup tests

Author: schrothbn

packages/@n8n/nodes-langchain/nodes/retrievers/RetrieverVectorStore/test/RetrieverVectorStore.node.test.ts

@@ -46,7 +46,7 @@ describe('RetrieverVectorStore', () => {
 				0,
 			);
 			expect(mockVectorStore.asRetriever).toHaveBeenCalledWith(4);
-			expect(result.response).toBeDefined();
+			expect(result).toHaveProperty('response', { test: 'retriever' });
 		});
 
 		it('should create a retriever with custom topK parameter', async () => {
@@ -62,7 +62,7 @@ describe('RetrieverVectorStore', () => {
 			const result = await retrieverNode.supplyData.call(mockContext, 0);
 
 			expect(mockVectorStore.asRetriever).toHaveBeenCalledWith(10);
-			expect(result.response).toBeDefined();
+			expect(result).toHaveProperty('response', { test: 'retriever' });
 		});
 
 		it('should create a ContextualCompressionRetriever when input contains reranker and vectorStore', async () => {
@@ -120,15 +120,14 @@ describe('RetrieverVectorStore', () => {
 			mockVectorStore.asRetriever = jest.fn().mockReturnValue({ test: 'retriever' });
 
 			mockContext.getNodeParameter.mockImplementation((_param, _itemIndex, defaultValue) => {
-				return defaultValue; // Always return default value
+				return defaultValue;
 			});
 			mockContext.getInputConnectionData.mockResolvedValue(mockVectorStore);
 
-			const result = await retrieverNode.supplyData.call(mockContext, 0);
+			await retrieverNode.supplyData.call(mockContext, 0);
 
 			expect(mockContext.getNodeParameter).toHaveBeenCalledWith('topK', 0, 4);
 			expect(mockVectorStore.asRetriever).toHaveBeenCalledWith(4);
-			expect(result.response).toBeDefined();
 		});
 	});
 });

packages/@n8n/nodes-langchain/nodes/vector_store/shared/createVectorStoreNode/operations/__tests__/retrieveOperation.test.ts

@@ -100,10 +100,8 @@ describe('handleRetrieveOperation', () => {
 
 		const result = await handleRetrieveOperation(mockContext, mockArgs, mockEmbeddings, 0);
 
-		// Should check useReranker parameter
 		expect(mockContext.getNodeParameter).toHaveBeenCalledWith('useReranker', 0, false);
 
-		// Should get vector store client with filters
 		expect(mockArgs.getVectorStoreClient).toHaveBeenCalledWith(
 			mockContext,
 			{ testFilter: 'value' },
@@ -115,9 +113,6 @@ describe('handleRetrieveOperation', () => {
 		expect(result).toHaveProperty('response', mockVectorStore);
 		expect(result).toHaveProperty('closeFunction');
 
-		// Should wrap vector store with logWrapper
-		expect(logWrapper).toHaveBeenCalledWith(mockVectorStore, mockContext);
-
 		// Should not try to get reranker input connection
 		expect(mockContext.getInputConnectionData).not.toHaveBeenCalled();
 	});
@@ -128,31 +123,17 @@ describe('handleRetrieveOperation', () => {
 
 		const result = await handleRetrieveOperation(mockContext, mockArgs, mockEmbeddings, 0);
 
-		// Should check useReranker parameter
 		expect(mockContext.getNodeParameter).toHaveBeenCalledWith('useReranker', 0, false);
 
-		// Should get reranker from input connection
 		expect(mockContext.getInputConnectionData).toHaveBeenCalledWith(
 			NodeConnectionTypes.AiReranker,
 			0,
 		);
 
-		// Should get vector store client with filters
-		expect(mockArgs.getVectorStoreClient).toHaveBeenCalledWith(
-			mockContext,
-			{ testFilter: 'value' },
-			mockEmbeddings,
-			0,
-		);
-
-		// Result should contain reranker and vector store object
 		expect(result.response).toEqual({
 			reranker: mockReranker,
 			vectorStore: mockVectorStore,
 		});
 		expect(result).toHaveProperty('closeFunction');
-
-		// Should wrap vector store with logWrapper for the vectorStore property
-		expect(logWrapper).toHaveBeenCalledWith(mockVectorStore, mockContext);
 	});
 });