Skip to content

fix(Email Trigger (IMAP) Node): Add Email UID also to email format "resolved" #15539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

Alexandero89
Copy link
Contributor

When returning the email in the format "simple" the UID is added and returned, but not when returned in format "resolved". This commit changes this

Summary

Its basically the same functionality as in the PR from #13152
It only adds the returned UID also when choosing format "resolved"

Related Linear tickets, Github issues, and Community forum posts

Forum feature request IMAP Trigger Node - Provide email UIDs
GitHub issue: umanamente/n8n-nodes-imap#42

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created. NO DOCS AVAILABLE IN BASELINE
  • Tests included. NO TESTS AVAILABLE IN BASELINE
  • PR Labeled with release/backport NO NEED

When return the email in the format "simple" the UID is added and returned, but not when returned in format "parsed".
This commit changes this
@CLAassistant
Copy link

CLAassistant commented May 20, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic reviewed 1 file and found no issues. Review PR in cubic.dev.

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request in linear Issue or PR has been created in Linear for internal review labels May 20, 2025
@Joffcom
Copy link
Member

Joffcom commented May 20, 2025

Hey @Alexandero89,

Thanks for the PR, We have created "GHC-2079" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

@ShireenMissi ShireenMissi self-requested a review June 9, 2025 17:41
@ShireenMissi ShireenMissi changed the title Adding Email UID also to email format "resolved" fix(Email Trigger (IMAP) Node): Add Email UID also to email format "resolved" Jun 9, 2025
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works as expected ✅

@ShireenMissi ShireenMissi merged commit 33f8fab into n8n-io:master Jun 9, 2025
27 of 28 checks passed
Copy link

cypress bot commented Jun 10, 2025

n8n    Run #11367

Run Properties:  status check passed Passed #11367  •  git commit 33f8fab791: 🌳 master 🤖 PR User 🗃️ e2e/*
Project n8n
Branch Review master
Run status status check passed Passed #11367
Run duration 04m 08s
Commit git commit 33f8fab791: 🌳 master 🤖 PR User 🗃️ e2e/*
Committer Alexandero89
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 503
View all changes introduced in this branch ↗︎

@janober
Copy link
Member

janober commented Jun 11, 2025

Got released with [email protected]

TianYi0217 pushed a commit to TianYi0217/n8n that referenced this pull request Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants