-
Notifications
You must be signed in to change notification settings - Fork 34.1k
fix(Email Trigger (IMAP) Node): Add Email UID also to email format "resolved" #15539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Email Trigger (IMAP) Node): Add Email UID also to email format "resolved" #15539
Conversation
When return the email in the format "simple" the UID is added and returned, but not when returned in format "parsed". This commit changes this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cubic reviewed 1 file and found no issues. Review PR in cubic.dev.
Hey @Alexandero89, Thanks for the PR, We have created "GHC-2079" as the internal reference to get this reviewed. One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and it works as expected ✅
n8n
|
Project |
n8n
|
Branch Review |
master
|
Run status |
|
Run duration | 04m 08s |
Commit |
|
Committer | Alexandero89 |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
10
|
|
0
|
|
503
|
View all changes introduced in this branch ↗︎ |
Got released with |
When returning the email in the format "simple" the UID is added and returned, but not when returned in format "resolved". This commit changes this
Summary
Its basically the same functionality as in the PR from #13152
It only adds the returned UID also when choosing format "resolved"
Related Linear tickets, Github issues, and Community forum posts
Forum feature request IMAP Trigger Node - Provide email UIDs
GitHub issue: umanamente/n8n-nodes-imap#42
Review / Merge checklist
release/backport
NO NEED