-
Notifications
You must be signed in to change notification settings - Fork 34.1k
feat(core): Add support for partial-match execution filters #15797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Add support for partial-match execution filters #15797
Conversation
c9ed068
to
7b6bc5c
Compare
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
7b6bc5c
to
be43856
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cubic found 6 issues across 8 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai
to give specific feedback.
packages/frontend/editor-ui/src/components/executions/ExecutionsFilter.vue
Show resolved
Hide resolved
packages/frontend/editor-ui/src/components/executions/ExecutionsFilter.vue
Show resolved
Hide resolved
packages/frontend/editor-ui/src/components/executions/ExecutionsFilter.vue
Show resolved
Hide resolved
packages/frontend/editor-ui/src/components/executions/ExecutionsFilter.vue
Show resolved
Hide resolved
packages/frontend/editor-ui/src/components/executions/ExecutionsFilter.vue
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Tested it locally with Sqlite and Postgres and worked fine. Nice work 🚀
Workflow Test Results 📊 🔴 3 Failed,
|
Workflow ID | Workflow Name | Reason |
---|---|---|
237 | BasicLLMChain:AzureChat | Workflow contains 1 deleted data. |
243 | Agent:ReAct | Workflow contains 2 deleted data. |
253 | Agent:Tools:OpenAI | Premature close on node AI Agent2 |
⚠️ Warnings (2)
Workflow ID | Workflow Name | Reason |
---|---|---|
53 | ConvertKit:CustomField:create getAll update delete... | Workflow contains new data that previously did not exist. |
257 | Agent:auto-fix:anthropic | Workflow contains new data that previously did not exist. |
✅ All Cypress E2E specs passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work locally and implementation looks good 👍
EDIT: oh, ricardo beat me to reviewing this :D
packages/frontend/editor-ui/src/components/executions/ExecutionsFilter.vue
Show resolved
Hide resolved
Workflow Test Results 📊 🔴 1 Failed,
|
Workflow ID | Workflow Name | Reason |
---|---|---|
237 | BasicLLMChain:AzureChat | Workflow contains 1 deleted data. |
⚠️ Warnings (4)
Workflow ID | Workflow Name | Reason |
---|---|---|
35 | Slack:User:getPresence info:UserProfile:get update... | Workflow contains new data that previously did not exist. |
257 | Agent:auto-fix:anthropic | Workflow contains new data that previously did not exist. |
53 | ConvertKit:CustomField:create getAll update delete... | Workflow contains new data that previously did not exist. |
48 | Asana:Project:getAll get:Task:create update move g... | Workflow contains new data that previously did not exist. |
✅ All Cypress E2E specs passed |
Got released with |
Summary
This PR adds support for partial-matching when filtering executions and introduces a checkbox for choosing this setting, with a default set to partial matching.
I left the default on backend as exact matching as it is a more expensive operation.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-2926/feature-add-a-way-to-look-for-executions-via-contains-instead-of-exact
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)