Skip to content

feat(core): Add support for partial-match execution filters #15797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dariacodes
Copy link
Contributor

@dariacodes dariacodes commented May 28, 2025

Summary

This PR adds support for partial-matching when filtering executions and introduces a checkbox for choosing this setting, with a default set to partial matching.
I left the default on backend as exact matching as it is a more expensive operation.

image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-2926/feature-add-a-way-to-look-for-executions-via-contains-instead-of-exact

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels May 28, 2025
@dariacodes dariacodes force-pushed the ado-2926-feature-add-a-way-to-look-for-executions-via-contains branch from c9ed068 to 7b6bc5c Compare May 28, 2025 14:06
Copy link

codecov bot commented May 28, 2025

Codecov Report

Attention: Patch coverage is 54.28571% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...s/@n8n/db/src/repositories/execution.repository.ts 0.00% 10 Missing ⚠️
...-ui/src/components/executions/ExecutionsFilter.vue 76.00% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

@dariacodes dariacodes force-pushed the ado-2926-feature-add-a-way-to-look-for-executions-via-contains branch from 7b6bc5c to be43856 Compare June 2, 2025 08:01
@dariacodes dariacodes marked this pull request as ready for review June 2, 2025 15:06
@n8n-io n8n-io deleted a comment Jun 2, 2025
@n8n-io n8n-io deleted a comment Jun 2, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic found 6 issues across 8 files. Review them in cubic.dev

React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.

@dariacodes dariacodes requested review from Cadiac and RicardoE105 June 2, 2025 18:46
Copy link
Contributor

@RicardoE105 RicardoE105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Tested it locally with Sqlite and Postgres and worked fine. Nice work 🚀

@shortstacked
Copy link
Contributor

Workflow Test Results 📊 🔴 3 Failed, ⚠️ 2 Warnings, 👍 78 Successful out of 83 total workflows.

Detail: Workflows failing: 237: Workflow contains 1 deleted data. View full workflow run

Tested Ref: 877545bef34db331c0b9087711f71f0ed05b4daa by @RicardoE105

❌ Failed Tests (3)

Workflow ID Workflow Name Reason
237 BasicLLMChain:AzureChat Workflow contains 1 deleted data.
243 Agent:ReAct Workflow contains 2 deleted data.
253 Agent:Tools:OpenAI Premature close on node AI Agent2

⚠️ Warnings (2)

Workflow ID Workflow Name Reason
53 ConvertKit:CustomField:create getAll update delete... Workflow contains new data that previously did not exist.
257 Agent:auto-fix:anthropic Workflow contains new data that previously did not exist.

Copy link
Contributor

github-actions bot commented Jun 2, 2025

✅ All Cypress E2E specs passed

Copy link
Contributor

@Cadiac Cadiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work locally and implementation looks good 👍

EDIT: oh, ricardo beat me to reviewing this :D

@shortstacked
Copy link
Contributor

Workflow Test Results 📊 🔴 1 Failed, ⚠️ 4 Warnings, 👍 78 Successful out of 83 total workflows.

Detail: Workflows failing: 237: Workflow contains 1 deleted data. View full workflow run

Tested Ref: 877545bef34db331c0b9087711f71f0ed05b4daa by @Cadiac

❌ Failed Tests (1)

Workflow ID Workflow Name Reason
237 BasicLLMChain:AzureChat Workflow contains 1 deleted data.

⚠️ Warnings (4)

Workflow ID Workflow Name Reason
35 Slack:User:getPresence info:UserProfile:get update... Workflow contains new data that previously did not exist.
257 Agent:auto-fix:anthropic Workflow contains new data that previously did not exist.
53 ConvertKit:CustomField:create getAll update delete... Workflow contains new data that previously did not exist.
48 Asana:Project:getAll get:Task:create update move g... Workflow contains new data that previously did not exist.

Copy link
Contributor

github-actions bot commented Jun 3, 2025

✅ All Cypress E2E specs passed

@dariacodes dariacodes merged commit 1335af0 into master Jun 4, 2025
71 checks passed
@dariacodes dariacodes deleted the ado-2926-feature-add-a-way-to-look-for-executions-via-contains branch June 4, 2025 06:37
Alexandero89 pushed a commit to Alexandero89/n8n that referenced this pull request Jun 4, 2025
Alexandero89 pushed a commit to Alexandero89/n8n that referenced this pull request Jun 4, 2025
@github-actions github-actions bot mentioned this pull request Jun 11, 2025
This was referenced Jun 11, 2025
@janober
Copy link
Member

janober commented Jun 11, 2025

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants