fix(Local File Trigger Node): Fix ignored option on Mac os #15872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic found 1 issue across 2 files. Review it in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
packages/nodes-base/nodes/LocalFileTrigger/LocalFileTrigger.node.ts
Outdated
Show resolved
Hide resolved
ShireenMissi
force-pushed
the
node-2520-community-issue-local-file-trigger-ignore-option-does-not-ignore-files
branch
from
7d10238 to
9082648
Compare
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
n8n team
ShireenMissi
force-pushed
the
node-2520-community-issue-local-file-trigger-ignore-option-does-not-ignore-files
branch
from
9082648 to
b4747c6
Compare
elsmr
reviewed
Jun 6, 2025
packages/nodes-base/nodes/LocalFileTrigger/LocalFileTrigger.node.ts
Outdated
Show resolved
Hide resolved
packages/nodes-base/nodes/LocalFileTrigger/LocalFileTrigger.node.ts
Outdated
Show resolved
Hide resolved
packages/nodes-base/nodes/LocalFileTrigger/LocalFileTrigger.node.ts
Outdated
Show resolved
Hide resolved
|
I tested it on mac and it works as expected :) just left some comments on copy |
ShireenMissi
force-pushed
the
node-2520-community-issue-local-file-trigger-ignore-option-does-not-ignore-files
branch
from
b4747c6 to
a428473
Compare
ShireenMissi
force-pushed
the
node-2520-community-issue-local-file-trigger-ignore-option-does-not-ignore-files
branch
from
a428473 to
8ff830d
Compare
elsmr
reviewed
Jun 9, 2025
elsmr
approved these changes
Jun 10, 2025
|
✅ All Cypress E2E specs passed |
ShireenMissi
deleted the
node-2520-community-issue-local-file-trigger-ignore-option-does-not-ignore-files
branch
This was referenced Jun 11, 2025
Closed
Closed
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new "Ignore Mode" option to the Local File Trigger node, allowing users to choose between:
Regex (default): standard regex ignore patterns using anymatch syntax.
Function: wraps the ignored value in a function (e.g. (path) => path.includes(value)) to match paths programmatically.
This change addresses a known issue with Chokidar on macOS, where the default ignore behavior using regex does not reliably filter paths. See Chokidar Issue #773 for details.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-2520/community-issue-local-file-trigger-ignore-option-does-not-ignore-files
https://community.n8n.io/t/local-file-trigger-not-ignore-file-paterns/84654/2
fixes #13711
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)