Skip to content

fix(editor): Add user role tooltip to personal settings page #15941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cstuncsik
Copy link
Contributor

Summary

Show account type when viewing personal settings on an instance

Related Linear tickets, Github issues, and Community forum posts

PAY-2643

Review / Merge checklist

  • PR title and summary are descriptive.
  • Tests included.
  • PR Labeled with release/backport

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic found 3 issues across 2 files. Review them in cubic.dev

React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jun 2, 2025
@cstuncsik cstuncsik requested a review from r00gm June 3, 2025 09:08
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

r00gm
r00gm previously approved these changes Jun 3, 2025
Copy link
Contributor

@r00gm r00gm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good just a small comments on the types

@shortstacked
Copy link
Contributor

Workflow Test Results 📊 🔴 1 Failed, ⚠️ 4 Warnings, 👍 78 Successful out of 83 total workflows.

Detail: Workflows failing: 237: Workflow contains 1 deleted data. View full workflow run

Tested Ref: 1d006d99121fe676bed234edc6979d0e085ac7a3 by @r00gm

❌ Failed Tests (1)

Workflow ID Workflow Name Reason
237 BasicLLMChain:AzureChat Workflow contains 1 deleted data.

⚠️ Warnings (4)

Workflow ID Workflow Name Reason
35 Slack:User:getPresence info:UserProfile:get update... Workflow contains new data that previously did not exist.
257 Agent:auto-fix:anthropic Workflow contains new data that previously did not exist.
53 ConvertKit:CustomField:create getAll update delete... Workflow contains new data that previously did not exist.
48 Asana:Project:getAll get:Task:create update move g... Workflow contains new data that previously did not exist.

Copy link
Contributor

github-actions bot commented Jun 3, 2025

✅ All Cypress E2E specs passed

Approve review suggestion

Co-authored-by: Raúl Gómez Morales <[email protected]>
cstuncsik and others added 2 commits June 3, 2025 13:25
Approve review suggestion

Co-authored-by: Raúl Gómez Morales <[email protected]>
Approve review suggestion

Co-authored-by: Raúl Gómez Morales <[email protected]>
@cstuncsik cstuncsik requested a review from r00gm June 3, 2025 11:25
r00gm
r00gm previously approved these changes Jun 3, 2025
@shortstacked
Copy link
Contributor

Workflow Test Results 📊 🔴 2 Failed, ⚠️ 4 Warnings, 👍 77 Successful out of 83 total workflows.

Detail: Workflows failing: 237: Workflow contains 1 deleted data. View full workflow run

Tested Ref: 5328e5b8b1dfd6963261d12327387cdfc633e101 by @r00gm

❌ Failed Tests (2)

Workflow ID Workflow Name Reason
237 BasicLLMChain:AzureChat Workflow contains 1 deleted data.
243 Agent:ReAct Workflow contains 2 deleted data.

⚠️ Warnings (4)

Workflow ID Workflow Name Reason
35 Slack:User:getPresence info:UserProfile:get update... Workflow contains new data that previously did not exist.
48 Asana:Project:getAll get:Task:create update move g... Workflow contains new data that previously did not exist.
53 ConvertKit:CustomField:create getAll update delete... Workflow contains new data that previously did not exist.
257 Agent:auto-fix:anthropic Workflow contains new data that previously did not exist.

Copy link
Contributor

github-actions bot commented Jun 3, 2025

✅ All Cypress E2E specs passed

@shortstacked
Copy link
Contributor

Workflow Test Results 📊 🔴 2 Failed, ⚠️ 4 Warnings, 👍 77 Successful out of 83 total workflows.

Detail: Workflows failing: 237: Workflow contains 1 deleted data. View full workflow run

Tested Ref: 8450bb8f47ac33aaff6237ad1dcb366c214ee252 by @r00gm

❌ Failed Tests (2)

Workflow ID Workflow Name Reason
237 BasicLLMChain:AzureChat Workflow contains 1 deleted data.
243 Agent:ReAct Workflow contains 2 deleted data.

⚠️ Warnings (4)

Workflow ID Workflow Name Reason
35 Slack:User:getPresence info:UserProfile:get update... Workflow contains new data that previously did not exist.
53 ConvertKit:CustomField:create getAll update delete... Workflow contains new data that previously did not exist.
48 Asana:Project:getAll get:Task:create update move g... Workflow contains new data that previously did not exist.
257 Agent:auto-fix:anthropic Workflow contains new data that previously did not exist.

Copy link
Contributor

github-actions bot commented Jun 3, 2025

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik merged commit 2c9c3da into master Jun 3, 2025
36 checks passed
@cstuncsik cstuncsik deleted the pay-2643-show-account-type-when-viewing-personal-settings-on-an branch June 3, 2025 12:52
Alexandero89 pushed a commit to Alexandero89/n8n that referenced this pull request Jun 4, 2025
Alexandero89 pushed a commit to Alexandero89/n8n that referenced this pull request Jun 4, 2025
@janober
Copy link
Member

janober commented Jun 11, 2025

Got released with [email protected]

TianYi0217 pushed a commit to TianYi0217/n8n that referenced this pull request Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants