perf(core): Don't load task-runner on main instances when manual executions are offloaded to workers #15986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions are offloaded to workers
n8n-assistant
bot
added
core
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic reviewed 1 file and found no issues. Review PR in cubic.dev.
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
ivov
reviewed
Jun 4, 2025
Comment on lines
+200
to
+203
| if (process.env.OFFLOAD_MANUAL_EXECUTIONS_TO_WORKERS === 'true') { | ||
| this.needsTaskRunner = false; | ||
| } | ||
|
|
There was a problem hiding this comment.
Should add a test for this? There's a very similar one at packages/cli/src/commands/__tests__/execute.test.ts
There was a problem hiding this comment.
Gave it a try but as usual commands are painful to test, so this little change is not worth the time. Let's disentangle this command some other time.
ivov
approved these changes
Jun 6, 2025
|
✅ All Cypress E2E specs passed |
ivov
changed the title
ivov
deleted the
no-task-runner-in-main-when-manual-exeutions-are-offloaded
branch
This was referenced Jun 11, 2025
Closed
Closed
Merged
|
Got released with |
TianYi0217
pushed a commit
to TianYi0217/n8n
that referenced
this pull request
Jun 14, 2025
…tions are offloaded to workers (n8n-io#15986)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When manual executions offloading is enabled, there are no executions on main instances, and therefore there is no need to be running a task-runner subprocess.
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)