fix(editor): Position executions filter popover so that it doesn't hide executions #16049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic found 2 issues across 2 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
packages/frontend/editor-ui/src/components/executions/workflow/WorkflowExecutionsSidebar.vue
Show resolved
Hide resolved
Cadiac
force-pushed
the
ado-3608-feature-open-execution-filters-modal-in-the-right
branch
2 times, most recently
from
5731c59 to
f6008b8
Compare
Cadiac
force-pushed
the
ado-3608-feature-open-execution-filters-modal-in-the-right
branch
from
f6008b8 to
468695d
Compare
CharlieKolb
previously approved these changes
Jun 5, 2025
Workflow Test Results 📊 🔴 2 Failed,
|
| Workflow ID | Workflow Name | Reason |
|---|---|---|
| 237 | BasicLLMChain:AzureChat | Workflow contains 1 deleted data. |
| 84 | Matrix:Room:create invite kick leave:RoomMember:ge... | Too Many Requests on node Matrix1 |
⚠️ Warnings (4)
| Workflow ID | Workflow Name | Reason |
|---|---|---|
| 35 | Slack:User:getPresence info:UserProfile:get update... | Workflow contains new data that previously did not exist. |
| 257 | Agent:auto-fix:anthropic | Workflow contains new data that previously did not exist. |
| 53 | ConvertKit:CustomField:create getAll update delete... | Workflow contains new data that previously did not exist. |
| 48 | Asana:Project:getAll get:Task:create update move g... | Workflow contains new data that previously did not exist. |
|
✅ All Cypress E2E specs passed |
CharlieKolb
approved these changes
Jun 6, 2025
|
✅ All Cypress E2E specs passed |
Cadiac
deleted the
ado-3608-feature-open-execution-filters-modal-in-the-right
branch
This was referenced Jun 11, 2025
Closed
Closed
Merged
|
Got released with |
TianYi0217
pushed a commit
to TianYi0217/n8n
that referenced
this pull request
Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Open the executions filter to the right of the button so that it doesn't hide the executions list while open.
Doing so revealed some ugliness, the leave animation was way too long and looked weird
executions-list-leave-animation.mp4
So I made it faster & not translate back to left, instead just moving and disappearing up.
execution-list-leave-fast.mp4
This animation isn't perfect either, but it is still an improvement - at least in my opinion.
The ticket also mentions this filter not closing if user clicks outside it. The filter popover seems to close correctly if user clicks outside it on any regular UI elements, but not if they click on the canvas - I'm assuming the canvas prevents the click event and popover doesn't become aware of it, and I'm not spend time looking for a fix on it now I think. Now that the popover doesn't cover most of the normal UI elements this should be less of an issue.
Third suggestion on that ticket is starting to list available Execution Data keys on the picker. We don't have that data efficiently available and while a backend for it could be added + we could change the component to a a picker that fetches options from backend, but I think that's unrelated to this PR.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-3608/feature-open-execution-filters-modal-in-the-right
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)