fix(core): Don't swallow connection errors when fetching credentials #16181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
core
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic reviewed 2 files and found no issues. Review PR in cubic.dev.
ivov
approved these changes
Jun 11, 2025
|
✅ All Cypress E2E specs passed |
This could also help a little: https://www.typescriptlang.org/tsconfig/#useUnknownInCatchVariables |
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We have had multiple reports of executions failing, because the credential could not be found:
Credential with ID "305" does not exist for type "googleBigQueryOAuth2Api".Sometimes these have been false positives, because the error thrown by TypeORM was actually a connection error that we just ignore.
This PR first checks if the error thrown is an
EntityNotFoundErrorbefore replacing it with aCredentialNotFoundError.If it's any other error it will be re-thrown so that user reports contain the correct error when they report this. (most of the time it's this, but we can't be sure because we're hiding it).
Related Linear tickets, Github issues, and Community forum posts
https://n8nio.slack.com/archives/C035KBDA917/p1748612791750639
Review / Merge checklist
Docs updated or follow-up ticket created.PR Labeled withrelease/backport(if the PR is an urgent fix that needs to be backported)