cksum: switch to uucore::hardware for --debug\n\n- Remove local hardware module and cpufeatures dependency\n- Enable uucore 'hardware' feature in uu_cksum\n- Print CPU feature info via uucore instead of local module\n\nRefs: uutils#9279

Author: naoNao89

Cargo.lock

@@ -19,13 +19,15 @@ path = "src/cksum.rs"
 
 [dependencies]
 clap = { workspace = true }
-uucore = { workspace = true, features = ["checksum", "encoding", "sum"] }
+uucore = { workspace = true, features = [
+  "checksum",
+  "encoding",
+  "sum",
+  "hardware",
+] }
 hex = { workspace = true }
 fluent = { workspace = true }
 
-[target.'cfg(all(any(target_arch = "x86_64", target_arch = "aarch64", target_arch = "loongarch64", target_arch = "x86"), not(target_os = "android")))'.dependencies]
-cpufeatures = { workspace = true }
-
 [dev-dependencies]
 divan = { workspace = true }
 tempfile = { workspace = true }

fuzz/Cargo.lock

@@ -5,11 +5,8 @@
 
 // spell-checker:ignore (ToDO) fname, algo, bitlen
 
-mod hardware;
-
 use clap::builder::ValueParser;
 use clap::{Arg, ArgAction, Command};
-use hardware::CpuFeatures;
 use std::ffi::{OsStr, OsString};
 use std::iter;
 use uucore::checksum::compute::{
@@ -23,14 +20,32 @@ use uucore::checksum::{
     sanitize_sha2_sha3_length_str,
 };
 use uucore::error::UResult;
+use uucore::hardware::CpuFeatures;
 use uucore::line_ending::LineEnding;
 use uucore::{format_usage, translate};
 
 /// Print CPU hardware capability detection information to stderr
 /// This matches GNU cksum's --debug behavior
 fn print_cpu_debug_info() {
     let features = CpuFeatures::detect();
-    features.print_debug();
+
+    fn print_feature(name: &str, available: bool) {
+        if available {
+            eprintln!("cksum: using {name} hardware support");
+        } else {
+            eprintln!("cksum: {name} support not detected");
+        }
+    }
+
+    // x86/x86_64
+    print_feature("avx512", features.has_avx512());
+    print_feature("avx2", features.has_avx2());
+    print_feature("pclmul", features.has_pclmul());
+
+    // ARM aarch64
+    if cfg!(target_arch = "aarch64") {
+        print_feature("vmull", features.has_vmull());
+    }
 }
 
 mod options {
@@ -192,11 +207,17 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> {
         matches.get_flag(options::BASE64),
     );
 
+    // Print hardware debug info if requested
+    if matches.get_flag(options::DEBUG) {
+        print_cpu_debug_info();
+    }
+
     let opts = ChecksumComputeOptions {
         algo_kind: algo,
         output_format,
         line_ending,
-        debug: matches.get_flag(options::DEBUG),
+        binary,
+        no_names: false,
     };
 
     perform_checksum_computation(opts, files)?;