ci: Upgrade the CI base image to use ubuntu-24.04 instead of the deprecated ubuntu-20.04 (#359)

Author: frol

.github/workflows/rust.yml

@@ -21,7 +21,7 @@ jobs:
     strategy:
       matrix:
         rust_version: [1.67, stable]
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
 
     steps:
     - uses: actions/checkout@v4
@@ -36,16 +36,23 @@ jobs:
       run: rustup default ${{ matrix.rust_version }}
     - name: print rustc version
       run: rustc --version
-    - name: downgrade `serde_bytes` crate to support older Rust toolchain
+    - name: downgrade `serde_bytes`, `toml_edit`, and `toml_parser` crates to support older Rust toolchain
       if: matrix.rust_version == '1.67'
       run: |
         cargo update -p serde_bytes --precise 0.11.16
+        cargo update -p toml_edit --precise 0.23.5
+        cargo update -p toml_parser --precise 1.0.2
+        cargo update -p toml_datetime --precise 0.7.1
+        cargo update -p indexmap@2.12.0 --precise 2.11.4
+        cargo update -p syn@2.0.110 --precise 2.0.106
+        cargo update -p quote --precise 1.0.41
+        cargo update -p time --precise 0.3.41
     - name: Run tests
       run: ./.github/test.sh
 
   # remove this job when https://github.com/rust-lang/rust/issues/89554 stabilizes
   test_exhaustive_checks:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
     steps:
     - uses: actions/checkout@v4
     - name: Install nightly for exhaustive check tests
@@ -58,15 +65,15 @@ jobs:
       run: RUSTFLAGS="-A unused_imports -D warnings" cargo check --workspace --features force_exhaustive_checks
 
   clippy:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
 
     steps:
     - uses: actions/checkout@v4
     - name: Run clippy
       run: cargo clippy --features unstable__schema --benches -- -D clippy::all
 
   cargo-fmt:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
 
     steps:
     - uses: actions/checkout@v4
@@ -77,7 +84,7 @@ jobs:
   # won't look as expected, when rendered, and sometimes errors, which will prevent doc from being
   # generated at release time altogether.
   cargo-doc:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
 
     steps:
     - uses: actions/checkout@v4

borsh/src/schema/container_ext/max_size.rs

@@ -94,7 +94,7 @@ fn max_serialized_size_impl<'a>(
         mul(count, sum)
     }
 
-    if stack.iter().any(|dec| *dec == declaration) {
+    if stack.contains(&declaration) {
         return Err(Error::Recursive);
     }
     stack.push(declaration);
@@ -205,7 +205,7 @@ fn is_zero_size_impl<'a>(
         Ok(true)
     }
 
-    if stack.iter().any(|dec| *dec == declaration) {
+    if stack.contains(&declaration) {
         return Err(ZeroSizeError::Recursive);
     }
     stack.push(declaration);

borsh/src/schema/container_ext/validate.rs

@@ -65,7 +65,7 @@ fn validate_impl<'a>(
             return Err(Error::MissingDefinition(declaration.to_string()));
         }
     };
-    if stack.iter().any(|dec| *dec == declaration) {
+    if stack.contains(&declaration) {
         return Ok(());
     }
     stack.push(declaration);

borsh/tests/compile_derives/test_generic_enums.rs

@@ -15,13 +15,15 @@ use std::collections::HashMap;
 use alloc::collections::BTreeMap;
 
 /// `T: Ord` bound is required for `BorshDeserialize` derive to be successful
+#[allow(unused)]
 #[derive(BorshSerialize, BorshDeserialize, PartialEq, Debug)]
 enum E<T: Ord, U, W> {
     X { f: BTreeMap<T, U> },
     Y(W),
 }
 
 #[cfg(hash_collections)]
+#[allow(unused)]
 #[derive(BorshSerialize, BorshDeserialize, Debug)]
 enum I1<K, V, R> {
     B {
@@ -34,6 +36,7 @@ enum I1<K, V, R> {
 }
 
 #[cfg(hash_collections)]
+#[allow(unused)]
 #[derive(BorshSerialize, BorshDeserialize, Debug)]
 enum I2<K: Ord + Eq + Hash, R, U> {
     B { x: HashMap<K, R>, y: String },

borsh/tests/compile_derives/test_macro_namespace_collisions.rs

@@ -3,9 +3,11 @@
 mod std {}
 mod core {}
 
+#[allow(unused)]
 #[derive(borsh::BorshSerialize, borsh::BorshDeserialize)]
 struct A;
 
+#[allow(unused)]
 #[derive(borsh::BorshSerialize, borsh::BorshDeserialize)]
 enum B {
     C,

borsh/tests/compile_derives/test_recursive_structs.rs

@@ -12,6 +12,7 @@ use alloc::{boxed::Box, string::String};
 
 
 #[cfg(hash_collections)]
+#[allow(unused)]
 #[derive(BorshSerialize, BorshDeserialize)]
 struct CRec<U: Ord + Hash + Eq> {
     a: String,
@@ -20,6 +21,7 @@ struct CRec<U: Ord + Hash + Eq> {
 
 //  `impl<T, U> BorshDeserialize for Box<T>` pulls in => `ToOwned`
 // => pulls in at least `Clone`
+#[allow(unused)]
 #[derive(Clone, BorshSerialize, BorshDeserialize)]
 struct CRecA {
     a: String,
@@ -28,6 +30,7 @@ struct CRecA {
 
 
 #[cfg(hash_collections)]
+#[allow(unused)]
 #[derive(BorshSerialize, BorshDeserialize)]
 struct CRecC {
     a: String,

borsh/tests/roundtrip/requires_derive_category/test_enum_discriminants.rs

@@ -134,6 +134,20 @@ enum C {
     C5(D),
 }
 
+#[test]
+fn test_enum_tuples() {
+    let values = vec![
+        C::C1,
+        C::C2(u64::MAX),
+        C::C3(1, 2),
+        C::C4 { x: 0, y: 100 },
+        C::C5(D { x: u64::MAX }),
+    ];
+    for value in values {
+        assert_eq!(from_slice::<C>(&to_vec(&value).unwrap()).unwrap(), value);
+    }
+}
+
 #[derive(BorshSerialize, BorshDeserialize, PartialEq, Eq, Clone, Copy, Debug)]
 #[borsh(use_discriminant = true)]
 enum X {