Fix blips in the transaction pool size metric (#9174)

Right now the metric has noticeable blips due to rapid change when transactions are drawn from the pool: https://nearinc.grafana.net/goto/YZwyDllVR?orgId=1 To avoid this, we only decrease the metric after the pool iterator is dropped.

This is a part of #3284

Author: aborg-dev

chain/pool/src/lib.rs

@@ -218,19 +218,12 @@ impl<'a> PoolIterator for PoolIteratorWrapper<'a> {
             self.pool.last_used_key = key;
             let mut transactions =
                 self.pool.transactions.remove(&key).expect("just checked existence");
-            // See the comment in `insert_transaction` above where we increase the size for
-            // reasoning why panicing here catches a logic error.
-            self.pool.total_transaction_size = self
-                .pool
-                .total_transaction_size
-                .checked_sub(transactions.iter().map(|tx| tx.get_size()).sum())
-                .expect("Total transaction size dropped below zero");
-            metrics::TRANSACTION_POOL_SIZE.set(self.pool.transaction_size() as i64);
             transactions.sort_by_key(|st| std::cmp::Reverse(st.transaction.nonce));
             self.sorted_groups.push_back(TransactionGroup {
                 key,
                 transactions,
                 removed_transaction_hashes: vec![],
+                removed_transaction_size: 0,
             });
             Some(self.sorted_groups.back_mut().expect("just pushed"))
         } else {
@@ -260,14 +253,15 @@ impl<'a> Drop for PoolIteratorWrapper<'a> {
             for hash in group.removed_transaction_hashes {
                 self.pool.unique_transactions.remove(&hash);
             }
+            // See the comment in `insert_transaction` where we increase the size for reasoning
+            // why panicing here catches a logic error.
+            self.pool.total_transaction_size = self
+                .pool
+                .total_transaction_size
+                .checked_sub(group.removed_transaction_size)
+                .expect("Total transaction size dropped below zero");
+
             if !group.transactions.is_empty() {
-                // See the comment in `insert_transaction` where we increase the size for reasoning
-                // why panicing here catches a logic error.
-                self.pool.total_transaction_size = self
-                    .pool
-                    .total_transaction_size
-                    .checked_add(group.transactions.iter().map(|tx| tx.get_size()).sum())
-                    .expect("Total transaction size is too large");
                 self.pool.transactions.insert(group.key, group.transactions);
             }
         }

chain/pool/src/types.rs

@@ -21,6 +21,8 @@ pub struct TransactionGroup {
     pub(crate) transactions: Vec<SignedTransaction>,
     /// Hashes of the transactions that were pulled from the group using `.next()`.
     pub(crate) removed_transaction_hashes: Vec<CryptoHash>,
+    /// Total size of transactions that were pulled from the group using `.next()`.
+    pub(crate) removed_transaction_size: u64,
 }
 
 impl TransactionGroup {
@@ -29,6 +31,7 @@ impl TransactionGroup {
     pub fn next(&mut self) -> Option<SignedTransaction> {
         if let Some(tx) = self.transactions.pop() {
             self.removed_transaction_hashes.push(tx.get_hash());
+            self.removed_transaction_size += tx.get_size();
             Some(tx)
         } else {
             None