Use team keys for authors (#88)

* Use  keys for  config

* Update context stub and add github test

* Update with docs response for team members

* Updates per PR comments

* Run build

* Fix lint errors

* Try to build again

* Response in data

Author: hbrysiewicz

dist/index.js

@@ -112,6 +112,17 @@ async function assign_reviewers(reviewers) {
   });
 }
 
+// https://docs.github.com/en/rest/teams/members?apiVersion=2022-11-28#list-team-members
+async function get_team_members(team) {
+  const context = get_context();
+  const octokit = get_octokit();
+
+  return octokit.teams.listMembersInOrg({
+    org: context.repo.org,
+    team_slug: team,
+  })?.data?.map((member) => member.login);
+}
+
 /* Private */
 
 let context_cache;
@@ -158,4 +169,5 @@ module.exports = {
   fetch_changed_files,
   assign_reviewers,
   clear_cache,
+  get_team_members,
 };

src/github.js

@@ -3,6 +3,7 @@
 const core = require('@actions/core');
 const minimatch = require('minimatch');
 const sample_size = require('lodash/sampleSize');
+const github = require('./github'); // Don't destructure this object to stub with sinon in tests
 
 function fetch_other_group_members({ author, config }) {
   const DEFAULT_OPTIONS = {
@@ -77,6 +78,14 @@ function identify_reviewers_by_author({ config, 'author': specified_author }) {
       return true;
     }
 
+    if (author.startsWith('team:')) {
+      const team = author.replace('team:', '');
+      const individuals_in_team = github.get_team_members(team);
+      if (individuals_in_team.includes(specified_author)) {
+        return true;
+      }
+    }
+
     const individuals_in_author_setting = replace_groups_with_individuals({ reviewers: [ author ], config });
 
     if (individuals_in_author_setting.includes(specified_author)) {

src/reviewer.js

@@ -14,6 +14,7 @@ const {
   fetch_changed_files,
   assign_reviewers,
   clear_cache,
+  get_team_members,
 } = require('../src/github');
 
 describe('github', function() {
@@ -155,4 +156,29 @@ describe('github', function() {
       });
     });
   });
+
+  describe('get_team_members()', function() {
+    const spy = sinon.spy();
+    const octokit = {
+      teams: {
+        listMembersInOrg: spy,
+      },
+    };
+
+    beforeEach(function() {
+      github.getOctokit.resetBehavior();
+      github.getOctokit.returns(octokit);
+    });
+
+    it('gets team members', async function() {
+      const team = 'koopa-troop';
+      await get_team_members(team);
+
+      expect(spy.calledOnce).to.be.true;
+      expect(spy.lastCall.args[0]).to.deep.equal({
+        org: 'necojackarc',
+        team_slug: 'koopa-troop',
+      });
+    });
+  });
 });

test/github.test.js

@@ -10,6 +10,9 @@ const {
 } = require('../src/reviewer');
 const { expect } = require('chai');
 
+const github = require('../src/github');
+const sinon = require('sinon');
+
 describe('reviewer', function() {
   describe('fetch_other_group_members()', function() {
 
@@ -69,7 +72,6 @@ describe('reviewer', function() {
   });
 
   describe('identify_reviewers_by_changed_files()', function() {
-
     const config = {
       reviewers: {
         groups: {
@@ -136,13 +138,30 @@ describe('reviewer', function() {
           designers: [ 'mario', 'princess-peach', 'princess-daisy' ],
         },
         per_author: {
-          engineers: [ 'engineers', 'dr-mario' ],
-          designers: [ 'designers' ],
-          yoshi: [ 'mario', 'luige' ],
+          'engineers': [ 'engineers', 'dr-mario' ],
+          'designers': [ 'designers' ],
+          'yoshi': [ 'mario', 'luige' ],
+          'team:koopa-troop': [ 'mario' ],
         },
       },
     };
 
+    const stub = sinon.stub(github, 'get_team_members');
+    stub.withArgs('koopa-troop').returns([
+      {
+        login: 'bowser',
+        id: 1,
+      },
+      {
+        login: 'king-boo',
+        id: 2,
+      },
+      {
+        login: 'goomboss',
+        id: 3,
+      },
+    ]);
+
     it('returns nothing when config does not have a "per-author" key', function() {
       const author = 'THIS DOES NOT MATTER';
       expect(identify_reviewers_by_author({ config: { reviewers: {} }, author })).to.deep.equal([]);
@@ -167,6 +186,11 @@ describe('reviewer', function() {
       const author = 'mario';
       expect(identify_reviewers_by_author({ config, author })).to.have.members([ 'dr-mario', 'luigi', 'wario', 'waluigi', 'princess-peach', 'princess-daisy' ]);
     });
+
+    it('works when gh team slug used for auther', function() {
+      const author = 'bowser';
+      expect(identify_reviewers_by_author({ config, author })).to.have.members([ 'mario' ]);
+    });
   });
 
   describe('should_request_review()', function() {

test/reviewer.test.js

@@ -24,6 +24,7 @@ class ContextStub {
     return {
       owner: 'necojackarc',
       repo: 'auto-request-review',
+      org: 'necojackarc',
     };
   }
 }