Remove relate by UI dependency#1689
Merged
eijawerner merged 10 commits intoFeb 28, 2022
Merged
Conversation
eijawerner
force-pushed
the
remove-relate-by-ui-dependency
branch
2 times, most recently
from
d0c8352 to
a1aa281
Compare
removed dependency to semantic-ui button and fixed styling so looked the same as before.
Also, removed deps "@trivago/prettier-plugin-sort-imports" since it reorders also imports with side effects, like the order of the import of the style files. Reordered the style imports back to as it was in release 4.3.2. When this is released (with an option to not reorder imports with side effects) trivago/prettier-plugin-sort-imports#111 we can add the plugin again.
eijawerner
force-pushed
the
remove-relate-by-ui-dependency
branch
from
691ca70 to
6fef18a
Compare
OskarDamkjaer
requested changes
Feb 28, 2022
Contributor
OskarDamkjaer
left a comment
OskarDamkjaer
left a comment
There was a problem hiding this comment.
Nice work! The getting rid of this dependency had a long time coming, good to get all the unused code into the open... Let's hope we can get rid of that as well soon!
I left a few comments for you to have a look at! 💯
OskarDamkjaer
approved these changes
Feb 28, 2022
Contributor
OskarDamkjaer
left a comment
OskarDamkjaer
left a comment
There was a problem hiding this comment.
Changes look good! Let's merge on green ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the dependency to relate-by-ui.
to check how the Browser looks like in this PR you can visit: http://browser-remove-deps.surge.sh
Known changes: