Skip to content

Commit 59940f6

Browse files
committed
Only build NavigationPaneHelper on Windows
Signed-off-by: Claudio Cambra <[email protected]>
1 parent 84e7da5 commit 59940f6

File tree

3 files changed

+23
-5
lines changed

3 files changed

+23
-5
lines changed

src/gui/CMakeLists.txt

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,6 @@ set(client_SRCS
109109
lockwatcher.cpp
110110
logbrowser.h
111111
logbrowser.cpp
112-
navigationpanehelper.h
113-
navigationpanehelper.cpp
114112
networksettings.h
115113
networksettings.cpp
116114
ocsnavigationappsjob.h
@@ -289,13 +287,19 @@ IF( APPLE )
289287
ENDIF()
290288

291289
IF( NOT WIN32 AND NOT APPLE )
292-
set(client_SRCS ${client_SRCS} folderwatcher_linux.cpp)
290+
set(client_SRCS ${client_SRCS} folderwatcher_linux.cpp)
293291
ENDIF()
294292
IF( WIN32 )
295-
set(client_SRCS ${client_SRCS} folderwatcher_win.cpp shellextensionsserver.cpp ${CMAKE_SOURCE_DIR}/src/common/shellextensionutils.cpp)
293+
set(client_SRCS
294+
${client_SRCS}
295+
folderwatcher_win.cpp
296+
navigationpanehelper.h
297+
navigationpanehelper.cpp
298+
shellextensionsserver.cpp
299+
${CMAKE_SOURCE_DIR}/src/common/shellextensionutils.cpp)
296300
ENDIF()
297301
IF( APPLE )
298-
list(APPEND client_SRCS folderwatcher_mac.cpp)
302+
list(APPEND client_SRCS folderwatcher_mac.cpp)
299303
ENDIF()
300304

301305
set(3rdparty_SRC

src/gui/folderman.cpp

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,9 @@ FolderMan *FolderMan::_instance = nullptr;
5454
FolderMan::FolderMan(QObject *parent)
5555
: QObject(parent)
5656
, _lockWatcher(new LockWatcher)
57+
#ifdef Q_OS_WIN
5758
, _navigationPaneHelper(this)
59+
#endif
5860
{
5961
ASSERT(!_instance);
6062
_instance = this;
@@ -1191,7 +1193,9 @@ Folder *FolderMan::addFolder(AccountState *accountState, const FolderDefinition
11911193
emit folderListChanged(_folderMap);
11921194
}
11931195

1196+
#ifdef Q_OS_WIN
11941197
_navigationPaneHelper.scheduleUpdateCloudStorageRegistry();
1198+
#endif
11951199
return folder;
11961200
}
11971201

@@ -1211,10 +1215,12 @@ Folder *FolderMan::addFolderInternal(
12111215

12121216
auto folder = new Folder(folderDefinition, accountState, std::move(vfs), this);
12131217

1218+
#ifdef Q_OS_WIN
12141219
if (_navigationPaneHelper.showInExplorerNavigationPane() && folderDefinition.navigationPaneClsid.isNull()) {
12151220
folder->setNavigationPaneClsid(QUuid::createUuid());
12161221
folder->saveToSettings();
12171222
}
1223+
#endif
12181224

12191225
qCInfo(lcFolderMan) << "Adding folder to Folder Map " << folder << folder->alias();
12201226
_folderMap[folder->alias()] = folder;
@@ -1313,7 +1319,9 @@ void FolderMan::removeFolder(Folder *f)
13131319
delete f;
13141320
}
13151321

1322+
#ifdef Q_OS_WIN
13161323
_navigationPaneHelper.scheduleUpdateCloudStorageRegistry();
1324+
#endif
13171325

13181326
emit folderListChanged(_folderMap);
13191327
}
@@ -1450,7 +1458,9 @@ void FolderMan::slotWipeFolderForAccount(AccountState *accountState)
14501458
delete f;
14511459
}
14521460

1461+
#ifdef Q_OS_WIN
14531462
_navigationPaneHelper.scheduleUpdateCloudStorageRegistry();
1463+
#endif
14541464
}
14551465

14561466
emit folderListChanged(_folderMap);

src/gui/folderman.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,9 @@
2222

2323
#include "folder.h"
2424
#include "folderwatcher.h"
25+
#ifdef Q_OS_WIN
2526
#include "navigationpanehelper.h"
27+
#endif
2628
#include "syncfileitem.h"
2729

2830
class TestFolderMan;
@@ -379,7 +381,9 @@ private slots:
379381
bool _nextSyncShouldStartImmediately = false;
380382

381383
QScopedPointer<SocketApi> _socketApi;
384+
#ifdef Q_OS_WIN
382385
NavigationPaneHelper _navigationPaneHelper;
386+
#endif
383387

384388
bool _appRestartRequired = false;
385389

0 commit comments

Comments
 (0)