Skip to content

Commit 938b5b0

Browse files
committed
FIXUP
Signed-off-by: Iva Horn <[email protected]>
1 parent 2721e8e commit 938b5b0

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

.github/workflows/macos-build-and-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ jobs:
6262
env:
6363
CODE_SIGNING_REQUIRED: "NO"
6464
CODE_SIGNING_ALLOWED: "NO"
65-
CODE_SIGN_IDENTITY: "-"
65+
CODE_SIGN_IDENTITY: ""
6666
run: |
6767
python "${{ inputs.CRAFT_MASTER_LOCATION }}/CraftMaster.py" --config "${{ inputs.CRAFT_MASTER_CONFIG }}" --target ${{ inputs.CRAFT_TARGET }} -c --options nextcloud-client.srcDir=${{ github.workspace }} --options nextcloud-client.buildFileProviderModule=${{ inputs.buildFileProviderModule }} nextcloud-client
6868

shell_integration/MacOSX/NextcloudIntegration/NextcloudDev/Build.xcconfig

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,24 +5,27 @@
55
// The common name of the signing certificate to use for code signing.
66
// It must be present in your keychain and a development certificate.
77
//
8-
CODE_SIGN_IDENTITY=Apple Development
8+
CODE_SIGN_IDENTITY=$(CODE_SIGN_IDENTITY:default=Apple Development)
9+
10+
CODE_SIGNING_ALLOWED=$(CODE_SIGNING_ALLOWED:default=YES)
11+
CODE_SIGNING_REQUIRED=$(CODE_SIGNING_REQUIRED:default=YES)
912

1013
//
1114
// Xcode should automatically manage signing assets.
1215
//
13-
CODE_SIGN_STYLE = Automatic
16+
CODE_SIGN_STYLE=$(CODE_SIGN_STYLE:default=Automatic)
1417

1518
//
1619
// The development team identifier registered with Apple.
1720
//
18-
DEVELOPMENT_TEAM=NKUJUXUJ3B
21+
DEVELOPMENT_TEAM=$(DEVELOPMENT_TEAM:default=NKUJUXUJ3B)
1922

2023
//
2124
// The app name.
2225
//
23-
OC_APPLICATION_NAME=Nextcloud
26+
OC_APPLICATION_NAME=$(OC_APPLICATION_NAME:default=Nextcloud)
2427

2528
//
2629
// Reverse base identifier.
2730
//
28-
OC_APPLICATION_REV_DOMAIN=com.nextcloud.desktopclient
31+
OC_APPLICATION_REV_DOMAIN=$(OC_APPLICATION_REV_DOMAIN:default=com.nextcloud.desktopclient)

0 commit comments

Comments
 (0)