fix(CI): Disabling code signing for macOS by default.

Signed-off-by: Iva Horn <[email protected]>

Author: i2h3

.github/workflows/macos-build-and-test.yml

@@ -59,6 +59,11 @@ jobs:
           key: ${{ runner.os }}-craft-${{ hashFiles(inputs.CRAFT_MASTER_CONFIG) }}
 
       - name: Build nextcloud-client
+        env:
+          CODE_SIGNING_REQUIRED: "NO"
+          CODE_SIGNING_ALLOWED: "NO"
+          CODE_SIGN_IDENTITY: ""
+          CODE_SIGN_STYLE: "Manual"
         run: |
           python "${{ inputs.CRAFT_MASTER_LOCATION }}/CraftMaster.py" --config "${{ inputs.CRAFT_MASTER_CONFIG }}" --target ${{ inputs.CRAFT_TARGET }} -c --options nextcloud-client.srcDir=${{ github.workspace }} --options nextcloud-client.buildFileProviderModule=${{ inputs.buildFileProviderModule }} nextcloud-client
 

shell_integration/MacOSX/NextcloudIntegration/NextcloudDev/Build.xcconfig

@@ -2,27 +2,23 @@
 //  SPDX-License-Identifier: GPL-2.0-or-later
 
 //
-// The common name of the signing certificate to use for code signing.
-// It must be present in your keychain and a development certificate.
+// Codesigning is performed later on by Mac Crafter.
 //
-CODE_SIGN_IDENTITY=Apple Development
-
-//
-// Xcode should automatically manage signing assets.
-//
-CODE_SIGN_STYLE = Automatic
+CODE_SIGNING_ALLOWED=NO
+CODE_SIGNING_REQUIRED=NO
+CODE_SIGN_STYLE=Manual
 
 //
 // The development team identifier registered with Apple.
 //
-DEVELOPMENT_TEAM=NKUJUXUJ3B
+DEVELOPMENT_TEAM=$(DEVELOPMENT_TEAM:default=NKUJUXUJ3B)
 
 //
 // The app name.
 //
-OC_APPLICATION_NAME=Nextcloud
+OC_APPLICATION_NAME=$(OC_APPLICATION_NAME:default=Nextcloud)
 
 //
 // Reverse base identifier.
 //
-OC_APPLICATION_REV_DOMAIN=com.nextcloud.desktopclient
+OC_APPLICATION_REV_DOMAIN=$(OC_APPLICATION_REV_DOMAIN:default=com.nextcloud.desktopclient)

shell_integration/MacOSX/NextcloudIntegration/NextcloudDev/Craft.sh

@@ -15,11 +15,6 @@ if [ -f "$HOME/.zprofile" ]; then
     source "$HOME/.zprofile"
 fi
 
-if [ -z "${CODE_SIGN_IDENTITY}" ]; then
-    echo "Error: CODE_SIGN_IDENTITY is not defined or is empty!"
-    exit 1
-fi
-
 DESKTOP_CLIENT_PROJECT_ROOT="$SOURCE_ROOT/../../.."
 
 if [ -d "$DESKTOP_CLIENT_PROJECT_ROOT/admin/osx/mac-crafter" ]; then
@@ -36,5 +31,5 @@ swift run mac-crafter \
     --dev \
     --disable-auto-updater \
     --build-file-provider-module \
-    --code-sign-identity="$CODE_SIGN_IDENTITY" \
+    --code-sign-identity="Apple Development" \
     "$DESKTOP_CLIENT_PROJECT_ROOT"