Skip to content

Commit c9dc081

Browse files
claucambramgallien
authored andcommitted
Only build NavigationPaneHelper on Windows
Signed-off-by: Claudio Cambra <[email protected]>
1 parent 8385248 commit c9dc081

File tree

3 files changed

+23
-5
lines changed

3 files changed

+23
-5
lines changed

src/gui/CMakeLists.txt

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,6 @@ set(client_SRCS
109109
lockwatcher.cpp
110110
logbrowser.h
111111
logbrowser.cpp
112-
navigationpanehelper.h
113-
navigationpanehelper.cpp
114112
networksettings.h
115113
networksettings.cpp
116114
ocsnavigationappsjob.h
@@ -339,13 +337,19 @@ IF( APPLE )
339337
ENDIF()
340338

341339
IF( NOT WIN32 AND NOT APPLE )
342-
set(client_SRCS ${client_SRCS} folderwatcher_linux.cpp)
340+
set(client_SRCS ${client_SRCS} folderwatcher_linux.cpp)
343341
ENDIF()
344342
IF( WIN32 )
345-
set(client_SRCS ${client_SRCS} folderwatcher_win.cpp shellextensionsserver.cpp ${CMAKE_SOURCE_DIR}/src/common/shellextensionutils.cpp)
343+
set(client_SRCS
344+
${client_SRCS}
345+
folderwatcher_win.cpp
346+
navigationpanehelper.h
347+
navigationpanehelper.cpp
348+
shellextensionsserver.cpp
349+
${CMAKE_SOURCE_DIR}/src/common/shellextensionutils.cpp)
346350
ENDIF()
347351
IF( APPLE )
348-
list(APPEND client_SRCS folderwatcher_mac.cpp)
352+
list(APPEND client_SRCS folderwatcher_mac.cpp)
349353
ENDIF()
350354

351355
set(3rdparty_SRC

src/gui/folderman.cpp

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,9 @@ FolderMan *FolderMan::_instance = nullptr;
6262
FolderMan::FolderMan(QObject *parent)
6363
: QObject(parent)
6464
, _lockWatcher(new LockWatcher)
65+
#ifdef Q_OS_WIN
6566
, _navigationPaneHelper(this)
67+
#endif
6668
{
6769
ASSERT(!_instance);
6870
_instance = this;
@@ -1257,7 +1259,9 @@ Folder *FolderMan::addFolder(AccountState *accountState, const FolderDefinition
12571259
emit folderListChanged(_folderMap);
12581260
}
12591261

1262+
#ifdef Q_OS_WIN
12601263
_navigationPaneHelper.scheduleUpdateCloudStorageRegistry();
1264+
#endif
12611265
return folder;
12621266
}
12631267

@@ -1277,10 +1281,12 @@ Folder *FolderMan::addFolderInternal(
12771281

12781282
auto folder = new Folder(folderDefinition, accountState, std::move(vfs), this);
12791283

1284+
#ifdef Q_OS_WIN
12801285
if (_navigationPaneHelper.showInExplorerNavigationPane() && folderDefinition.navigationPaneClsid.isNull()) {
12811286
folder->setNavigationPaneClsid(QUuid::createUuid());
12821287
folder->saveToSettings();
12831288
}
1289+
#endif
12841290

12851291
qCInfo(lcFolderMan) << "Adding folder to Folder Map " << folder << folder->alias();
12861292
_folderMap[folder->alias()] = folder;
@@ -1414,7 +1420,9 @@ void FolderMan::removeFolder(Folder *folderToRemove)
14141420
delete folderToRemove;
14151421
}
14161422

1423+
#ifdef Q_OS_WIN
14171424
_navigationPaneHelper.scheduleUpdateCloudStorageRegistry();
1425+
#endif
14181426

14191427
emit folderListChanged(_folderMap);
14201428
}
@@ -1551,7 +1559,9 @@ void FolderMan::slotWipeFolderForAccount(AccountState *accountState)
15511559
delete f;
15521560
}
15531561

1562+
#ifdef Q_OS_WIN
15541563
_navigationPaneHelper.scheduleUpdateCloudStorageRegistry();
1564+
#endif
15551565
}
15561566

15571567
emit folderListChanged(_folderMap);

src/gui/folderman.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,9 @@
2323

2424
#include "folder.h"
2525
#include "folderwatcher.h"
26+
#ifdef Q_OS_WIN
2627
#include "navigationpanehelper.h"
28+
#endif
2729
#include "syncfileitem.h"
2830

2931
class TestFolderMan;
@@ -403,7 +405,9 @@ private slots:
403405
bool _nextSyncShouldStartImmediately = false;
404406

405407
QScopedPointer<SocketApi> _socketApi;
408+
#ifdef Q_OS_WIN
406409
NavigationPaneHelper _navigationPaneHelper;
410+
#endif
407411

408412
QPointer<UpdateE2eeFolderUsersMetadataJob> _removeE2eeShareJob;
409413

0 commit comments

Comments
 (0)