fix(windows): inode property may be missing for some entries: add it

when syncing in full mode (only local file system and no client DB
cache), verifies that inode has a strictly positive value and if not
ensure we will update it

close #9142

Signed-off-by: Matthieu Gallien <[email protected]>

Author: mgallien

src/libsync/discovery.cpp

@@ -1394,6 +1394,14 @@ void ProcessDirectoryJob::processFileAnalyzeLocalInfo(
                              << "dbEntry._modtime:" << dbEntry._modtime
                              << "localEntry.modtime:" << localEntry.modtime;
             _childModified = true;
+        } else if (!serverModified &&
+                   !noServerEntry &&
+                   dbEntry._fileSize == localEntry.size &&
+                   dbEntry._modtime == localEntry.modtime &&
+                   dbEntry._inode == 0 &&
+                   localEntry.inode > 0) {
+            item->_instruction = CSYNC_INSTRUCTION_UPDATE_METADATA;
+            item->_direction = SyncFileItem::Down;
         } else {
             // Local file was changed
             item->_instruction = CSYNC_INSTRUCTION_SYNC;

test/testlocaldiscovery.cpp

@@ -14,6 +14,7 @@
 #include <localdiscoverytracker.h>
 
 using namespace OCC;
+using namespace Qt::StringLiterals;
 
 class TestLocalDiscovery : public QObject
 {
@@ -971,6 +972,72 @@ private slots:
         QVERIFY(!fakeFolder.syncOnce());
         QCOMPARE(syncSpy.findItem(fileNameE)->_status, SyncFileItem::Status::Success);
     }
+
+    void testMissingInodeAndFixThem()
+    {
+        FakeFolder fakeFolder{FileInfo{}};
+
+        fakeFolder.remoteModifier().mkdir(u"A"_s);
+        fakeFolder.remoteModifier().mkdir(u"A/B"_s);
+        fakeFolder.remoteModifier().insert(u"textFile.txt"_s);
+        fakeFolder.remoteModifier().insert(u"document.md"_s);
+        fakeFolder.remoteModifier().insert(u"A/B/sub-folder.md"_s);
+
+        QVERIFY(fakeFolder.syncOnce());
+
+        auto documentFileRecord = SyncJournalFileRecord{};
+        QVERIFY(fakeFolder.syncJournal().getFileRecord(u"document.md"_s, &documentFileRecord));
+        QCOMPARE_GT(documentFileRecord._inode, 0);
+        documentFileRecord._inode = 0;
+        QVERIFY(fakeFolder.syncJournal().setFileRecord(documentFileRecord).isValid());
+
+        auto textFileFileRecord = SyncJournalFileRecord{};
+        QVERIFY(fakeFolder.syncJournal().getFileRecord(u"textFile.txt"_s, &textFileFileRecord));
+        QCOMPARE_GT(textFileFileRecord._inode, 0);
+        textFileFileRecord._inode = 0;
+        QVERIFY(fakeFolder.syncJournal().setFileRecord(textFileFileRecord).isValid());
+
+        auto aFolderFileRecord = SyncJournalFileRecord{};
+        QVERIFY(fakeFolder.syncJournal().getFileRecord(u"A"_s, &aFolderFileRecord));
+        QCOMPARE_GT(aFolderFileRecord._inode, 0);
+        aFolderFileRecord._inode = 0;
+        QVERIFY(fakeFolder.syncJournal().setFileRecord(aFolderFileRecord).isValid());
+
+        auto bFolderFileRecord = SyncJournalFileRecord{};
+        QVERIFY(fakeFolder.syncJournal().getFileRecord(u"A/B"_s, &bFolderFileRecord));
+        QCOMPARE_GT(bFolderFileRecord._inode, 0);
+        bFolderFileRecord._inode = 0;
+        QVERIFY(fakeFolder.syncJournal().setFileRecord(bFolderFileRecord).isValid());
+
+        auto subFolderFileRecord = SyncJournalFileRecord{};
+        QVERIFY(fakeFolder.syncJournal().getFileRecord(u"A/B/sub-folder.md"_s, &subFolderFileRecord));
+        QCOMPARE_GT(subFolderFileRecord._inode, 0);
+        subFolderFileRecord._inode = 0;
+        QVERIFY(fakeFolder.syncJournal().setFileRecord(subFolderFileRecord).isValid());
+
+        fakeFolder.syncEngine().setLocalDiscoveryOptions(LocalDiscoveryStyle::FilesystemOnly);
+        QVERIFY(fakeFolder.syncOnce());
+
+        documentFileRecord = SyncJournalFileRecord{};
+        QVERIFY(fakeFolder.syncJournal().getFileRecord(u"document.md"_s, &documentFileRecord));
+        QCOMPARE_GT(documentFileRecord._inode, 0);
+
+        textFileFileRecord = SyncJournalFileRecord{};
+        QVERIFY(fakeFolder.syncJournal().getFileRecord(u"textFile.txt"_s, &textFileFileRecord));
+        QCOMPARE_GT(textFileFileRecord._inode, 0);
+
+        aFolderFileRecord = SyncJournalFileRecord{};
+        QVERIFY(fakeFolder.syncJournal().getFileRecord(u"A"_s, &aFolderFileRecord));
+        QCOMPARE_GT(aFolderFileRecord._inode, 0);
+
+        bFolderFileRecord = SyncJournalFileRecord{};
+        QVERIFY(fakeFolder.syncJournal().getFileRecord(u"A/B"_s, &bFolderFileRecord));
+        QCOMPARE_GT(bFolderFileRecord._inode, 0);
+
+        subFolderFileRecord = SyncJournalFileRecord{};
+        QVERIFY(fakeFolder.syncJournal().getFileRecord(u"A/B/sub-folder.md"_s, &subFolderFileRecord));
+        QCOMPARE_GT(subFolderFileRecord._inode, 0);
+    }
 };
 
 QTEST_GUILESS_MAIN(TestLocalDiscovery)