fix: Add a timeout to the minio.Stop() so that it gets killed

asalkeld · asalkeld · commit 81808b9f149d · 2022-02-03T10:00:39.000+10:00
diff --git a/pkg/run/minio.go b/pkg/run/minio.go
@@ -19,6 +19,7 @@ import (
 	"fmt"
 	"os"
 	"path/filepath"
+	"time"
 
 	"github.com/docker/docker/api/types/container"
 	"github.com/docker/docker/api/types/mount"
@@ -126,7 +127,8 @@ func (m *MinioServer) GetApiPort() int {
 }
 
 func (m *MinioServer) Stop() error {
-	return m.ce.Stop(m.cid, nil)
+	timeout := time.Second * 5
+	return m.ce.Stop(m.cid, &timeout)
 }
 
 func NewMinio(dir string, name string) (*MinioServer, error) {

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@ import (`
`19`	`19`	`"fmt"`
`20`	`20`	`"os"`
`21`	`21`	`"path/filepath"`
	`22`	`+ "time"`
`22`	`23`
`23`	`24`	`"github.com/docker/docker/api/types/container"`
`24`	`25`	`"github.com/docker/docker/api/types/mount"`
`@@ -126,7 +127,8 @@ func (m *MinioServer) GetApiPort() int {`
`126`	`127`	`}`
`127`	`128`
`128`	`129`	`func (m *MinioServer) Stop() error {`
`129`		`- return m.ce.Stop(m.cid, nil)`
	`130`	`+ timeout := time.Second * 5`
	`131`	`+ return m.ce.Stop(m.cid, &timeout)`
`130`	`132`	`}`
`131`	`133`
`132`	`134`	`func NewMinio(dir string, name string) (*MinioServer, error) {`