fix: correctly serves websites on start/run #863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures websites function correctly in both `nitric start` and `nitric run` modes. Introduces separate servers for each website when using `nitric start`, allowing them to run on individual ports. This resolves issues where websites were not being served correctly in development environments. For static serving (`nitric run`), it uses a single server with a shared port for all websites. Also, correctly strips the base path from the request URL when proxying requests to the target URL.
davemooreuws
force-pushed
the
fix/websites-dev
branch
from
48c89d9 to
2c87c14
Compare
tjholm
previously approved these changes
Apr 8, 2025
davemooreuws
force-pushed
the
fix/websites-dev
branch
from
29c7a44 to
3d41772
Compare
tjholm
approved these changes
Apr 9, 2025
HomelessDinosaur
approved these changes
Apr 15, 2025
|
🎉 This PR is included in version 1.59.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures websites function correctly in both
nitric startandnitric runmodes.Introduces separate servers for each website when using
nitric start, allowing them to run on individual ports. This resolves issues where websites were not being served correctly in development environments.For static serving (
nitric run), it uses a single server with a shared port for all websites.Also, correctly strips the base path from the request URL when proxying requests to the target URL.