Skip to content

Commit 790ca49

Browse files
authored
fix: ensure websockets work by fixing casting issue (#25)
* fix: export common resources Ensures permissions are included when importing nitric * fix: rename sendMessage to send for websockets * fix: rename closeConnection to close * fix: ensure websocker handler client is defined * fix imports
1 parent 126e47d commit 790ca49

File tree

6 files changed

+11
-9
lines changed

6 files changed

+11
-9
lines changed

lib/nitric.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,4 @@ library;
22

33
export 'src/nitric.dart';
44
export 'src/context/common.dart';
5+
export 'src/resources/common.dart';

lib/src/resources/websocket.dart

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,12 @@ class Websocket extends Resource {
1616
_websocketClient = websocketClient;
1717
}
1818

19-
_websocketHandlerClient = websocketHandlerClient;
19+
if (websocketHandlerClient == null) {
20+
_websocketHandlerClient = $wp.WebsocketHandlerClient(
21+
ClientChannelSingleton.instance.clientChannel);
22+
} else {
23+
_websocketHandlerClient = websocketHandlerClient;
24+
}
2025
}
2126

2227
@override
@@ -30,14 +35,14 @@ class Websocket extends Resource {
3035
}
3136

3237
/// Send message [data] to a connection, referenced by its [connectionId].
33-
Future<void> sendMessage(String connectionId, String data) async {
38+
Future<void> send(String connectionId, String data) async {
3439
var req = $wp.WebsocketSendRequest(
3540
socketName: name, connectionId: connectionId, data: utf8.encode(data));
3641
await _websocketClient.sendMessage(req);
3742
}
3843

3944
/// Close a connection to the socket, referenced by its [connectionId].
40-
Future<void> closeConnection(String connectionId) async {
45+
Future<void> close(String connectionId) async {
4146
var req = $wp.WebsocketCloseConnectionRequest(
4247
socketName: name, connectionId: connectionId);
4348
await _websocketClient.closeConnection(req);

lib/src/workers/common.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import 'dart:async';
33
import 'package:grpc/grpc.dart';
44

55
import 'package:nitric_sdk/nitric.dart';
6-
import 'package:nitric_sdk/resources.dart';
76
import 'package:nitric_sdk/src/api/api.dart';
87
import 'package:nitric_sdk/src/grpc_helper.dart';
98

test/src/resources/api_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import 'package:mocktail/mocktail.dart';
22
import 'package:nitric_sdk/nitric.dart';
33
import 'package:nitric_sdk/src/nitric/proto/apis/v1/apis.pbgrpc.dart' as $p;
44
import 'package:nitric_sdk/src/nitric/proto/resources/v1/resources.pb.dart';
5-
import 'package:nitric_sdk/src/resources/common.dart';
65
import 'package:test/test.dart';
76

87
import '../common.dart';

test/src/resources/bucket_test.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
import 'package:mocktail/mocktail.dart';
22
import 'package:nitric_sdk/nitric.dart';
3-
import 'package:nitric_sdk/resources.dart';
43
import 'package:nitric_sdk/src/nitric/proto/resources/v1/resources.pb.dart'
54
as $p;
65
import 'package:nitric_sdk/src/nitric/proto/storage/v1/storage.pbgrpc.dart'
76
as $sp;
8-
import 'package:nitric_sdk/src/resources/common.dart';
97
import 'package:test/test.dart';
108

119
import '../common.dart';

test/src/resources/websocket_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ void main() {
7171
var websocket = Websocket("socketName",
7272
client: resourceClient, websocketClient: websocketClient);
7373

74-
await websocket.sendMessage("connectionId", "hello world");
74+
await websocket.send("connectionId", "hello world");
7575

7676
verify(() => websocketClient.sendMessage(req)).called(1);
7777
});
@@ -90,7 +90,7 @@ void main() {
9090
var websocket = Websocket("socketName",
9191
client: resourceClient, websocketClient: websocketClient);
9292

93-
await websocket.closeConnection("connectionId");
93+
await websocket.close("connectionId");
9494

9595
verify(() => websocketClient.closeConnection(req)).called(1);
9696
});

0 commit comments

Comments
 (0)