fix: improve the error handling and wrapping

Author: asalkeld

pkg/cmd/run/root.go

@@ -24,6 +24,7 @@ import (
 	"syscall"
 	"time"
 
+	"github.com/pkg/errors"
 	"github.com/spf13/cobra"
 
 	"github.com/nitrictech/newcli/pkg/build"
@@ -45,7 +46,8 @@ var runCmd = &cobra.Command{
 		signal.Notify(term, os.Interrupt, syscall.SIGTERM)
 		signal.Notify(term, os.Interrupt, syscall.SIGINT)
 
-		ctx, _ := filepath.Abs(".")
+		ctx, err := filepath.Abs(".")
+		cobra.CheckErr(err)
 
 		files, err := filepath.Glob(filepath.Join(ctx, args[0]))
 		cobra.CheckErr(err)
@@ -97,7 +99,6 @@ var runCmd = &cobra.Command{
 			Pool:                    pool,
 			TolerateMissingServices: true,
 		})
-
 		cobra.CheckErr(err)
 
 		memerr := make(chan error)
@@ -119,9 +120,9 @@ var runCmd = &cobra.Command{
 
 		select {
 		case membraneError := <-memerr:
-			fmt.Println(fmt.Sprintf("Membrane Error: %v, exiting", membraneError))
+			fmt.Println(errors.WithMessage(membraneError, "membrane error, exiting"))
 		case sigTerm := <-term:
-			fmt.Println(fmt.Sprintf("Received %v, exiting", sigTerm))
+			fmt.Printf("Received %v, exiting\n", sigTerm)
 		}
 
 		for _, f := range functions {

pkg/provider/run/minio.go

@@ -55,12 +55,14 @@ const (
 // StartMinio -
 func (m *MinioServer) Start() error {
 	runDir, err := filepath.Abs(m.dir)
-
 	if err != nil {
 		return err
 	}
 
-	os.MkdirAll(runDir, runPerm)
+	err = os.MkdirAll(runDir, runPerm)
+	if err != nil {
+		return errors.WithMessage(err, "mkdirall")
+	}
 
 	// TODO: Create new buckets on the fly
 	//for bName := range l.s.Buckets {

pkg/templates/contents.go

@@ -18,13 +18,13 @@ package templates
 
 import (
 	"context"
-	"errors"
 	"fmt"
 	"os"
 	"path"
 	"path/filepath"
 
 	"github.com/hashicorp/go-getter"
+	"github.com/pkg/errors"
 	"gopkg.in/yaml.v2"
 
 	"github.com/nitrictech/newcli/pkg/utils"
@@ -90,17 +90,16 @@ func ListTemplates() (TemplatesConfig, error) {
 
 	// download file
 	if err := client.Get(); err != nil {
-		return TemplatesConfig{}, fmt.Errorf("Error getting path %s: %v", client.Src, err)
+		return TemplatesConfig{}, fmt.Errorf("error getting path %s: %v", client.Src, err)
 	}
 
 	var config, err = ReadTemplatesConfig()
-
 	if err != nil {
 		return TemplatesConfig{}, err
 	}
 
 	if config.Templates == nil {
-		return TemplatesConfig{}, errors.New("Templates array does not exist in respositories.yml")
+		return TemplatesConfig{}, errors.New("templates array does not exist in respositories.yml")
 	}
 
 	var transformedConfig = TemplatesConfig{}
@@ -139,10 +138,6 @@ func DownloadDirectoryContents(templatePath string, destDir string, force bool)
 
 	// TODO add spinner
 
-	// downloads files
-	if err := client.Get(); err != nil {
-		return fmt.Errorf("Error getting path %s: %v", client.Src, err)
-	}
-
-	return nil
+	err = client.Get()
+	return errors.WithMessagef(err, "error getting path %s", client.Src)
 }