Skip to content

Add then and catch methods to Promise class #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025

Conversation

miguelmarcondesf
Copy link
Contributor

Issue: 1667

@miguelmarcondesf miguelmarcondesf marked this pull request as ready for review June 14, 2025 20:28
@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2025

Codecov Report

Attention: Patch coverage is 53.84615% with 18 lines in your changes missing coverage. Please review.

Project coverage is 65.58%. Comparing base (0b70d4d) to head (e3dd851).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
napi-inl.h 53.84% 3 Missing and 15 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1668      +/-   ##
==========================================
- Coverage   65.79%   65.58%   -0.22%     
==========================================
  Files           3        3              
  Lines        2146     2185      +39     
  Branches      715      730      +15     
==========================================
+ Hits         1412     1433      +21     
- Misses        162      165       +3     
- Partials      572      587      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas
Copy link
Member

The CI failures are caused by missing of the definition of Promise::Promise().

@miguelmarcondesf
Copy link
Contributor Author

The CI failures are caused by missing of the definition of Promise::Promise().

Thank you, just fixed that!

@mhdawson mhdawson moved this from Need Triage to Has PR in Node-API Team Project Jun 20, 2025
Copy link
Contributor

@KevinEady KevinEady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly some changes on the docs... but the implementation looks good! Thanks for the contribution 👍

Copy link
Contributor

@KevinEady KevinEady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but some small nits / questions.

Note the the CI will fail until #1672 is merged and this branch is rebased.

@miguelmarcondesf
Copy link
Contributor Author

LGTM but some small nits / questions.

Note the the CI will fail until #1672 is merged and this branch is rebased.

Sounds good, thanks!

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legendecas legendecas merged commit ab3e5fe into nodejs:main Jul 4, 2025
54 checks passed
@github-project-automation github-project-automation bot moved this from Has PR to Done in Node-API Team Project Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

5 participants