-
-
Notifications
You must be signed in to change notification settings - Fork 481
Add then and catch methods to Promise class #1668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1668 +/- ##
==========================================
- Coverage 65.79% 65.58% -0.22%
==========================================
Files 3 3
Lines 2146 2185 +39
Branches 715 730 +15
==========================================
+ Hits 1412 1433 +21
- Misses 162 165 +3
- Partials 572 587 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The CI failures are caused by missing of the definition of |
Thank you, just fixed that! |
7e3a036
to
b594d54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly some changes on the docs... but the implementation looks good! Thanks for the contribution 👍
5f3f37d
to
d1430fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but some small nits / questions.
Note the the CI will fail until #1672 is merged and this branch is rebased.
d1430fd
to
c6a02da
Compare
Sounds good, thanks! |
c6a02da
to
e3dd851
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue: 1667