Skip to content

Commit 3f49174

Browse files
Trotttargos
Trott
authored and
targos
committed
doc: move who-to-cc to COLABORATOR_GUIDE.md
Put the "who to cc" information in the COLLABORATOR_GUIDE. The onboarding-extras doc is a bit of miscellaneous collection. Rather than stashing things in a junk drawer doc, put them where they are relevant. PR-URL: #19460 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 65c9a52 commit 3f49174

File tree

3 files changed

+54
-53
lines changed

3 files changed

+54
-53
lines changed

‎COLLABORATOR_GUIDE.md‎

Lines changed: 51 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
- [How are LTS Branches Managed?](#how-are-lts-branches-managed)
3636
- [How can I help?](#how-can-i-help)
3737
- [How is an LTS release cut?](#how-is-an-lts-release-cut)
38+
* [Who to CC in the issue tracker](#who-to-cc-in-the-issue-tracker)
3839

3940
This document contains information for Collaborators of the Node.js
4041
project regarding managing the project's code, documentation, and issue tracker.
@@ -53,7 +54,7 @@ requests they feel qualified to handle. Make sure this is done while being
5354
mindful of these guidelines, the opinions of other Collaborators, and guidance
5455
of the [TSC][]. They may also notify other qualified parties for more input on
5556
an issue or a pull request.
56-
[See "Who to CC in issues"](./doc/onboarding-extras.md#who-to-cc-in-issues)
57+
See [Who to CC in the issue tracker](#who-to-cc-in-the-issue-tracker).
5758

5859
### Welcoming First-Time Contributors
5960

@@ -118,7 +119,7 @@ Collaborator, an additional Collaborator is required for sign-off.
118119

119120
In some cases, it may be necessary to summon a GitHub team to a pull request for
120121
review by @-mention.
121-
[See "Who to CC in issues"](./doc/onboarding-extras.md#who-to-cc-in-issues).
122+
See [Who to CC in the issue tracker](#who-to-cc-in-the-issue-tracker).
122123

123124
If you are unsure about the modification and are not prepared to take
124125
full responsibility for the change, defer to another Collaborator.
@@ -821,6 +822,54 @@ selected commits will be picked from the staging branch to be included in the
821822
release. This process of making a release will be a collaboration between the
822823
LTS working group and the Release team.
823824

825+
## Who to CC in the issue tracker
826+
827+
| Subsystem | Maintainers |
828+
| --- | --- |
829+
| `benchmark/*` | @nodejs/benchmarking, @mscdex |
830+
| `bootstrap_node.js` | @nodejs/process |
831+
| `doc/*`, `*.md` | @nodejs/documentation |
832+
| `lib/assert` | @nodejs/testing |
833+
| `lib/async_hooks` | @nodejs/async\_hooks for bugs/reviews (+ @nodejs/diagnostics for API) |
834+
| `lib/buffer` | @nodejs/buffer |
835+
| `lib/child_process` | @nodejs/child\_process |
836+
| `lib/cluster` | @nodejs/cluster |
837+
| `lib/{crypto,tls,https}` | @nodejs/crypto |
838+
| `lib/dgram` | @nodejs/dgram |
839+
| `lib/domains` | @nodejs/domains |
840+
| `lib/fs`, `src/{fs,file}` | @nodejs/fs |
841+
| `lib/{_}http{*}` | @nodejs/http |
842+
| `lib/inspector.js`, `src/inspector_*` | @nodejs/V8-inspector |
843+
| `lib/internal/url`, `src/node_url` | @nodejs/url |
844+
| `lib/net` | @bnoordhuis, @indutny, @nodejs/streams |
845+
| `lib/repl` | @nodejs/repl |
846+
| `lib/{_}stream{*}` | @nodejs/streams |
847+
| `lib/timers` | @nodejs/timers |
848+
| `lib/util` | @nodejs/util |
849+
| `lib/zlib` | @nodejs/zlib |
850+
| `src/async-wrap.*` | @nodejs/async\_hooks |
851+
| `src/node_api.*` | @nodejs/n-api |
852+
| `src/node_crypto.*` | @nodejs/crypto |
853+
| `test/*` | @nodejs/testing |
854+
| `tools/node_modules/eslint`, `.eslintrc` | @nodejs/linting |
855+
| build | @nodejs/build |
856+
| `src/module_wrap.*`, `lib/internal/loader/*`, `lib/internal/vm/Module.js` | @nodejs/modules |
857+
| GYP | @nodejs/gyp |
858+
| performance | @nodejs/performance |
859+
| platform specific | @nodejs/platform-{aix,arm,freebsd,macos,ppc,smartos,s390,windows} |
860+
| python code | @nodejs/python |
861+
| upgrading c-ares | @rvagg |
862+
| upgrading http-parser | @nodejs/http, @nodejs/http2 |
863+
| upgrading libuv | @nodejs/libuv |
864+
| upgrading npm | @fishrock123, @MylesBorins |
865+
| upgrading V8 | @nodejs/V8, @nodejs/post-mortem |
866+
| Embedded use or delivery of Node.js | @nodejs/delivery-channels |
867+
868+
When things need extra attention, are controversial, or `semver-major`:
869+
@nodejs/tsc
870+
871+
If you cannot find who to cc for a file, `git shortlog -n -s <file>` may help.
872+
824873
[backporting guide]: doc/guides/backporting-to-release-lines.md
825874
[contributing]: ./doc/guides/contributing/pull-requests.md#commit-message-guidelines
826875
[Stability Index]: doc/api/documentation.md#stability-index

‎doc/onboarding-extras.md‎

Lines changed: 0 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -1,53 +1,5 @@
11
# Additional Onboarding Information
22

3-
## Who to CC in issues
4-
5-
| Subsystem | Maintainers |
6-
| --- | --- |
7-
| `benchmark/*` | @nodejs/benchmarking, @mscdex |
8-
| `bootstrap_node.js` | @nodejs/process |
9-
| `doc/*`, `*.md` | @nodejs/documentation |
10-
| `lib/assert` | @nodejs/testing |
11-
| `lib/async_hooks` | @nodejs/async\_hooks for bugs/reviews (+ @nodejs/diagnostics for API) |
12-
| `lib/buffer` | @nodejs/buffer |
13-
| `lib/child_process` | @nodejs/child\_process |
14-
| `lib/cluster` | @nodejs/cluster |
15-
| `lib/{crypto,tls,https}` | @nodejs/crypto |
16-
| `lib/dgram` | @nodejs/dgram |
17-
| `lib/domains` | @nodejs/domains |
18-
| `lib/fs`, `src/{fs,file}` | @nodejs/fs |
19-
| `lib/{_}http{*}` | @nodejs/http |
20-
| `lib/inspector.js`, `src/inspector_*` | @nodejs/v8-inspector |
21-
| `lib/internal/url`, `src/node_url` | @nodejs/url |
22-
| `lib/net` | @bnoordhuis, @indutny, @nodejs/streams |
23-
| `lib/repl` | @nodejs/repl |
24-
| `lib/{_}stream{*}` | @nodejs/streams |
25-
| `lib/timers` | @nodejs/timers |
26-
| `lib/util` | @nodejs/util |
27-
| `lib/zlib` | @nodejs/zlib |
28-
| `src/async-wrap.*` | @nodejs/async\_hooks |
29-
| `src/node_api.*` | @nodejs/n-api |
30-
| `src/node_crypto.*` | @nodejs/crypto |
31-
| `test/*` | @nodejs/testing |
32-
| `tools/node_modules/eslint`, `.eslintrc` | @nodejs/linting |
33-
| build | @nodejs/build |
34-
| `src/module_wrap.*`, `lib/internal/loader/*`, `lib/internal/vm/Module.js` | @nodejs/modules |
35-
| GYP | @nodejs/gyp |
36-
| performance | @nodejs/performance |
37-
| platform specific | @nodejs/platform-{aix,arm,freebsd,macos,ppc,smartos,s390,windows} |
38-
| python code | @nodejs/python |
39-
| upgrading c-ares | @rvagg |
40-
| upgrading http-parser | @nodejs/http, @nodejs/http2 |
41-
| upgrading libuv | @nodejs/libuv |
42-
| upgrading npm | @fishrock123, @MylesBorins |
43-
| upgrading V8 | @nodejs/v8, @nodejs/post-mortem |
44-
| Embedded use or delivery of Node.js | @nodejs/delivery-channels |
45-
46-
When things need extra attention, are controversial, or `semver-major`:
47-
@nodejs/tsc
48-
49-
If you cannot find who to cc for a file, `git shortlog -n -s <file>` may help.
50-
513
## Labels
524

535
### Subsystems

‎doc/onboarding.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ onboarding session.
2020
* Prior to the onboarding session, add the new Collaborator to
2121
[the Collaborators team](https://github.com/orgs/nodejs/teams/collaborators).
2222
* Ask them if they want to join any subsystem teams. See
23-
[Who to CC for Issues][who-to-cc].
23+
[Who to CC in the issue tracker][who-to-cc].
2424

2525
## Onboarding session
2626

@@ -96,7 +96,7 @@ onboarding session.
9696
* no outstanding review comments exist and
9797
* at least one collaborator approved the PR.
9898

99-
* [**See "Who to CC in issues"**][who-to-cc]
99+
* See [Who to CC in the issue tracker][who-to-cc].
100100
* This will come more naturally over time
101101
* For many of the teams listed there, you can ask to be added if you are
102102
interested
@@ -253,4 +253,4 @@ needs to be pointed out separately during the onboarding.
253253
[two-factor authentication]: https://help.github.com/articles/securing-your-account-with-two-factor-authentication-2fa/
254254
[Updating Node.js from Upstream]: ./onboarding-extras.md#updating-nodejs-from-upstream
255255
[using a TOTP mobile app]: https://help.github.com/articles/configuring-two-factor-authentication-via-a-totp-mobile-app/
256-
[who-to-cc]: ./onboarding-extras.md#who-to-cc-in-issues
256+
[who-to-cc]: ../COLLABORATOR_GUIDE.md#who-to-cc-in-the-issue-tracker

0 commit comments

Comments
 (0)