fix: dont warn on error cleaning individual log files#4134
Merged
lukekarrys merged 1 commit intorelease-nextfrom Dec 8, 2021
Merged
fix: dont warn on error cleaning individual log files#4134lukekarrys merged 1 commit intorelease-nextfrom
lukekarrys merged 1 commit intorelease-nextfrom
Conversation
wraithgar
reviewed
Dec 7, 2021
wraithgar
approved these changes
Dec 7, 2021
Member
wraithgar
left a comment
There was a problem hiding this comment.
My one tiny suggestion is in a test file and not a big deal.
Closes: #4128 This also refactors the logic for cleaning log files to use the `ignore` option from `glob` to not clean current log files instead of relying on updating the `logs-max` count. I also discovered a bug where we weren't cleaning log files written with the old naming convention, so this fixes that as well. PR-URL: #4134 Credit: @lukekarrys Close: #4134 Reviewed-by: @wraithgar
0b5ec9c to
08c6639
Compare
Contributor
|
found 4 benchmarks with statistically significant performance improvements
found 1 benchmarks with statistically significant performance regressions
timing results
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #4128
This also refactors the logic for cleaning log files to use the
ignoreoption from
globto not clean current log files instead of relying onupdating the
logs-maxcount.I also discovered a bug where we weren't cleaning log files written with
the old naming convention, so this fixes that as well.