Skip to content

Notify user when settings are applied #18029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Qchristensen opened this issue Apr 30, 2025 · 2 comments · May be fixed by #18215
Open

Notify user when settings are applied #18029

Qchristensen opened this issue Apr 30, 2025 · 2 comments · May be fixed by #18215
Labels
good first issue github features these at https://github.com/nvaccess/nvda/contribute p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. ux

Comments

@Qchristensen
Copy link
Member

Is your feature request related to a problem? Please describe.

  1. Open Notepad
  2. Type a capital. Observe whether NVDA beeps or not.
  3. Open speech settings (NVDA+control+v)
  4. Toggle "Beep for capitals" (alt+b)
  5. Press alt+tab to switch back to Notepad.
  6. Type a capital letter and observe that whether NVDA beeps has not changed.
  7. Alt+tab to switch back to speech settings
  8. Press alt+a to apply changes. Focus moves "Speech" in the categories list.
  9. Switch back to notepad and type a capital. Notice that whether NVDA beeps has now changed

When the apply button is pressed currently, focus moves to the category heading, but no indication is given that the changes have been applied.

Describe the solution you'd like

When the apply button is pressed, NVDA should report "Changes applied".

(This could also be reported when the OK button is pressed, as the changes are applied then also, it's just whether the dialog stays open or not which differs).

Describe alternatives you've considered

Additional context
@Qchristensen Qchristensen mentioned this issue Apr 30, 2025
Open
@Qchristensen
Copy link
Member Author

In testing this with the steps above, if you keep pressing alt+a, you can note that it will also jump to the speech variant option. I have separately created #18030 to aim to avoid conflicts and leave alt+a for apply and alt+c to jump to categories (at least in English).

@CyrilleB79
Copy link
Collaborator

It's true that the "Apply" UX with the focus jumping to category list is quite confusing, overall for new users. For a long time, I have believed that alt+a was an alternative shortcut for the category list. Maybe we can keep the focus on the "Apply" button after it is pressed to make it clearer?

Regarding the "OK" button, I am not in favor to add a confirmation message. It's rally standard that the modifications made in a dialog are being applied when OK is pressed and there's no need to add an additional message, which also may conflict with the new focus being reported.

@seanbudd seanbudd added p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority ux good first issue github features these at https://github.com/nvaccess/nvda/contribute triaged Has been triaged, issue is waiting for implementation. labels May 5, 2025
canacechen9 pushed a commit to canacechen9/nvda that referenced this issue Jun 4, 2025
Fixes nvaccess#18029: Keep focus on Apply button and show confirmatio…
cb4b2e9 
…n after applying settings
@canacechen9 canacechen9 linked a pull request Jun 4, 2025 that will close this issue
Open
5 tasks
canacechen9 pushed a commit to canacechen9/nvda that referenced this issue Jun 4, 2025
Revert "Fixes nvaccess#18029: Keep focus on Apply button and show con…
ed0b008 
…firmation after applying settings"

This reverts commit cb4b2e9.

reverting accidental commireverting accidental commireverting accidental
committt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue github features these at https://github.com/nvaccess/nvda/contribute p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #18029: Keep focus on Apply button and show confirmation after … canacechen9/nvda
3 participants
@seanbudd @Qchristensen @CyrilleB79