[BUG]: types don't resolve for `@octokit/core` on esm.sh

[thisguycodes]

What happened?

deno check ... consistently errors when using octokit via esm.sh

Versions

Octokit.js v4.0.2
Deno v2.0.6

Relevant log output

$ deno check *.ts **/*.ts --allow-import
error: Failed resolving types. Relative import path "@octokit/core/types" not prefixed with / or ./ or ../ and not in import map from "https://esm.sh/v135/octokit@4.0.2/X-ZS8q/dist-types/octokit.d.ts"
    at https://esm.sh/v135/octokit@4.0.2/X-ZS8q/dist-types/octokit.d.ts:4:59
$

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[wolfy1339]

This seems like an issue with esm.sh not resolving the import map

That import path is defined in package.json
https://unpkg.com/browse/@octokit/core@6.1.2/package.json (Line 67)

[thisguycodes]

I honestly don't know if I'm doing something wrong, I also opened an issue with esm.sh about a bug with their deno cli integration, and they told me they're deprecating it, so maybe it's got something to do with the way that added it to my import map?

here's what my import map looks like:

  "imports": {
    "deno-slack-api/": "https://deno.land/x/deno_slack_api@2.8.0/",
    "deno-slack-sdk/": "https://deno.land/x/deno_slack_sdk@2.14.2/",
    "mock-fetch/": "https://deno.land/x/mock_fetch@0.3.0/",
    "@octokit/webhooks-types": "https://esm.sh/v135/@octokit/webhooks-types@7.6.1",
    "octokit": "https://esm.sh/v135/*octokit@4.0.2",
    "@std/testing": "jsr:@std/testing@^1.0.5"
  },
  "scopes": {
    "https://esm.sh/v135/": {
      "@octokit/app": "https://esm.sh/v135/@octokit/app@15.1.1",
      "@octokit/core": "https://esm.sh/v135/@octokit/core@6.1.2",
      "@octokit/oauth-app": "https://esm.sh/v135/@octokit/oauth-app@7.1.3",
      "@octokit/plugin-paginate-graphql": "https://esm.sh/v135/@octokit/plugin-paginate-graphql@5.2.4",
      "@octokit/plugin-paginate-rest": "https://esm.sh/v135/@octokit/plugin-paginate-rest@11.3.5",
      "@octokit/plugin-rest-endpoint-methods": "https://esm.sh/v135/@octokit/plugin-rest-endpoint-methods@13.2.6",
      "@octokit/plugin-retry": "https://esm.sh/v135/@octokit/plugin-retry@7.1.2",
      "@octokit/plugin-throttling": "https://esm.sh/v135/@octokit/plugin-throttling@9.3.2",
      "@octokit/request-error": "https://esm.sh/v135/@octokit/request-error@6.1.5",
      "@octokit/types": "https://esm.sh/v135/@octokit/types@13.6.1"
    }
  }

[thisguycodes]

@wolfy1339 I notice you linked the @octokit/core package.json, but the error is saying it's not defined in the octokit package, is octokit somehow supposed to inherit the import map from @octokit/core?

(I genuinely have no idea how these things work)

[wolfy1339]

The octokit module is built on multiple other Octokit libraries packaged together, like @octokit/core, @octokit/app, @octokit/webhooks.

Sorry, I meant export map
https://nodejs.org/api/packages.html#exports

It defines the exports of that package, in that case, there's 2 exports.
./ is the main entrypoint
./types is a special entrypoint to access some types not exported in the main entrypoint but needed elsewhere.

The problem lies with esm.sh not using the export map in order to map the import to the correct file.

In the mean time, try adding the following to your scopes

"@octokit/core/types": "https://esm.sh/v135/@octokit/core@6.1.2/dist-types/types.d.ts",

Also, to prevent any type errors ditch the @octokit/webhooks-types package in favour of the @octokit/openapi-webhooks-types package. The former are not compatible with v4 of Octokit

[wolfy1339]

Closing as there is nothing else actionable for Octokit itself