From 409cee8aac2f7cda1e1bc5ec0b1b3b315e477346 Mon Sep 17 00:00:00 2001
From: chukunx <chx.devp@gmail.com>
Date: Tue, 25 Feb 2025 22:11:50 -0500
Subject: [PATCH] Reduce warning log about maxExportBatchSize.

---
 .../logs/export/BatchLogRecordProcessorBuilder.java   | 11 ++++-------
 .../sdk/trace/export/BatchSpanProcessorBuilder.java   | 11 ++++-------
 2 files changed, 8 insertions(+), 14 deletions(-)

diff --git a/sdk/logs/src/main/java/io/opentelemetry/sdk/logs/export/BatchLogRecordProcessorBuilder.java b/sdk/logs/src/main/java/io/opentelemetry/sdk/logs/export/BatchLogRecordProcessorBuilder.java
index e809acb951a..5e17848c774 100644
--- a/sdk/logs/src/main/java/io/opentelemetry/sdk/logs/export/BatchLogRecordProcessorBuilder.java
+++ b/sdk/logs/src/main/java/io/opentelemetry/sdk/logs/export/BatchLogRecordProcessorBuilder.java
@@ -107,9 +107,6 @@ long getExporterTimeoutNanos() {
    */
   public BatchLogRecordProcessorBuilder setMaxQueueSize(int maxQueueSize) {
     checkArgument(maxQueueSize > 0, "maxQueueSize must be positive.");
-    if (maxExportBatchSize > maxQueueSize) {
-      logger.log(Level.WARNING, "maxExportBatchSize should not exceed maxQueueSize.");
-    }
     this.maxQueueSize = maxQueueSize;
     return this;
   }
@@ -131,9 +128,6 @@ int getMaxQueueSize() {
    */
   public BatchLogRecordProcessorBuilder setMaxExportBatchSize(int maxExportBatchSize) {
     checkArgument(maxExportBatchSize > 0, "maxExportBatchSize must be positive.");
-    if (maxExportBatchSize > maxQueueSize) {
-      logger.log(Level.WARNING, "maxExportBatchSize should not exceed maxQueueSize.");
-    }
     this.maxExportBatchSize = maxExportBatchSize;
     return this;
   }
@@ -161,8 +155,11 @@ int getMaxExportBatchSize() {
    */
   public BatchLogRecordProcessor build() {
     if (maxExportBatchSize > maxQueueSize) {
+      logger.log(
+          Level.WARNING,
+          "maxExportBatchSize should not exceed maxQueueSize. Setting maxExportBatchSize to {0} instead of {1}",
+          new Object[] {maxQueueSize, maxExportBatchSize});
       maxExportBatchSize = maxQueueSize;
-      logger.log(Level.FINE, "Using maxExportBatchSize: {0}", maxExportBatchSize);
     }
     return new BatchLogRecordProcessor(
         logRecordExporter,
diff --git a/sdk/trace/src/main/java/io/opentelemetry/sdk/trace/export/BatchSpanProcessorBuilder.java b/sdk/trace/src/main/java/io/opentelemetry/sdk/trace/export/BatchSpanProcessorBuilder.java
index f968e35594a..d89083ded06 100644
--- a/sdk/trace/src/main/java/io/opentelemetry/sdk/trace/export/BatchSpanProcessorBuilder.java
+++ b/sdk/trace/src/main/java/io/opentelemetry/sdk/trace/export/BatchSpanProcessorBuilder.java
@@ -114,9 +114,6 @@ long getExporterTimeoutNanos() {
    */
   public BatchSpanProcessorBuilder setMaxQueueSize(int maxQueueSize) {
     checkArgument(maxQueueSize > 0, "maxQueueSize must be positive.");
-    if (maxExportBatchSize > maxQueueSize) {
-      logger.log(Level.WARNING, "maxExportBatchSize should not exceed maxQueueSize.");
-    }
     this.maxQueueSize = maxQueueSize;
     return this;
   }
@@ -138,9 +135,6 @@ int getMaxQueueSize() {
    */
   public BatchSpanProcessorBuilder setMaxExportBatchSize(int maxExportBatchSize) {
     checkArgument(maxExportBatchSize > 0, "maxExportBatchSize must be positive.");
-    if (maxExportBatchSize > maxQueueSize) {
-      logger.log(Level.WARNING, "maxExportBatchSize should not exceed maxQueueSize.");
-    }
     this.maxExportBatchSize = maxExportBatchSize;
     return this;
   }
@@ -168,8 +162,11 @@ int getMaxExportBatchSize() {
    */
   public BatchSpanProcessor build() {
     if (maxExportBatchSize > maxQueueSize) {
+      logger.log(
+          Level.WARNING,
+          "maxExportBatchSize should not exceed maxQueueSize. Setting maxExportBatchSize to {0} instead of {1}",
+          new Object[] {maxQueueSize, maxExportBatchSize});
       maxExportBatchSize = maxQueueSize;
-      logger.log(Level.FINE, "Using maxExportBatchSize: {0}", maxExportBatchSize);
     }
     return new BatchSpanProcessor(
         spanExporter,