feat(api-logs): add ObservedTimestamp to LogRecord#3787
Merged
dyladan merged 8 commits intoopen-telemetry:mainfrom May 19, 2023
Merged
feat(api-logs): add ObservedTimestamp to LogRecord#3787dyladan merged 8 commits intoopen-telemetry:mainfrom
ObservedTimestamp to LogRecord#3787dyladan merged 8 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3787 +/- ##
=======================================
Coverage 92.95% 92.95%
=======================================
Files 295 295
Lines 9038 9039 +1
Branches 1842 1843 +1
=======================================
+ Hits 8401 8402 +1
Misses 637 637
|
martinkuba
approved these changes
May 10, 2023
7af7fbf to
0451321
Compare
pichlermarc
approved these changes
May 10, 2023
scheler
approved these changes
May 10, 2023
scheler
reviewed
May 13, 2023
dyladan
reviewed
May 17, 2023
Member
dyladan
left a comment
There was a problem hiding this comment.
Generally looks good but you have to be very extra sure you want hrTime if you're going to use it. I personally would recommend using Date.now
cdb9c72 to
84125dc
Compare
dyladan
approved these changes
May 19, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Adds
ObservedTimestamptoLogRecordaccording to the specification.Fixes #3757
Short description of the changes
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: