fixed PR comments

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

Author: vinaykpud

CHANGELOG.md

@@ -6,7 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 ## [Unreleased 2.x]
 ### Added
 - Renaming the node role search to warm ([#17573](https://github.com/opensearch-project/OpenSearch/pull/17573))
-- Introduce a new search node role ([#17620](https://github.com/opensearch-project/OpenSearch/pull/17620))
+- Introduce a new search node role to hold search only shards ([#17620](https://github.com/opensearch-project/OpenSearch/pull/17620))
 
 ### Dependencies
 - Bump `ch.qos.logback:logback-core` from 1.5.16 to 1.5.17 ([#17609](https://github.com/opensearch-project/OpenSearch/pull/17609))

server/src/main/java/org/opensearch/cluster/node/DiscoveryNodeRole.java

@@ -317,14 +317,14 @@ public Setting<Boolean> legacySetting() {
 
         @Override
         public Setting<Boolean> legacySetting() {
-            // warm role is added in 3.0 so doesn't need to configure legacy setting
+            // search role is added in 2.4 so doesn't need to configure legacy setting
             return null;
         }
 
         @Override
         public void validateRole(List<DiscoveryNodeRole> roles) {
             for (DiscoveryNodeRole role : roles) {
-                if (!role.equals(DiscoveryNodeRole.SEARCH_ROLE)) {
+                if (role.equals(DiscoveryNodeRole.SEARCH_ROLE) == false) {
                     throw new IllegalArgumentException(
                         String.format(
                             Locale.ROOT,

server/src/test/java/org/opensearch/node/NodeRoleSettingsTests.java

@@ -48,7 +48,6 @@ public void testClusterManagerAndDataNodeRoles() {
      * Validate search role cannot coexist with any other role on a node.
      */
     public void testSearchRoleCannotCoExistWithAnyOtherRole() {
-        DiscoveryNode.setDeprecatedMasterRole();
         Settings roleSettings = Settings.builder().put(NodeRoleSettings.NODE_ROLES_SETTING.getKey(), "search, test_role").build();
         Exception exception = expectThrows(IllegalArgumentException.class, () -> NodeRoleSettings.NODE_ROLES_SETTING.get(roleSettings));
         assertThat(exception.getMessage(), containsString("search role cannot be combined with any other role on a node."));