Skip to content

Commit c177a3f

Browse files
authored
Merge branch 'opensearch-project:main' into star_tree_219
2 parents 204a107 + 3c55a31 commit c177a3f

File tree

32 files changed

+267
-475
lines changed

32 files changed

+267
-475
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
116116
- The `phone-search` analyzer no longer emits the tel/sip prefix, international calling code, extension numbers and unformatted input as a token ([#16993](https://github.com/opensearch-project/OpenSearch/pull/16993))
117117
- Stop processing search requests when _msearch request is cancelled ([#17005](https://github.com/opensearch-project/OpenSearch/pull/17005))
118118
- Fix GRPC AUX_TRANSPORT_PORT and SETTING_GRPC_PORT settings and remove lingering HTTP terminology ([#17037](https://github.com/opensearch-project/OpenSearch/pull/17037))
119+
- [WLM] Add WLM support for search scroll API ([#16981](https://github.com/opensearch-project/OpenSearch/pull/16981))
119120
- Fix exists queries on nested flat_object fields throws exception ([#16803](https://github.com/opensearch-project/OpenSearch/pull/16803))
120121
- Use OpenSearch version to deserialize remote custom metadata([#16494](https://github.com/opensearch-project/OpenSearch/pull/16494))
122+
- Fix AutoDateHistogramAggregator rounding assertion failure ([#17023](https://github.com/opensearch-project/OpenSearch/pull/17023))
123+
- Fix the failing CI's with `Failed to load eclipse jdt formatter` error ([#17172](https://github.com/opensearch-project/OpenSearch/pull/17172))
121124

122125
### Security
123126

gradle/formatting.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ allprojects {
8282
'\\#java|\\#org.opensearch|\\#org.hamcrest|\\#'
8383
)
8484

85-
eclipse().configFile rootProject.file('buildSrc/formatterConfig.xml')
85+
eclipse().withP2Mirrors(Map.of("https://download.eclipse.org/", "https://mirror.umd.edu/eclipse/")).configFile rootProject.file('buildSrc/formatterConfig.xml')
8686
trimTrailingWhitespace()
8787
endWithNewline()
8888

server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteRestoreSnapshotIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1143,7 +1143,7 @@ public void testConcurrentSnapshotV2CreateOperation_MasterChange() throws Except
11431143
.cluster()
11441144
.prepareCreateSnapshot(snapshotRepoName, snapshotName)
11451145
.setWaitForCompletion(true)
1146-
.setMasterNodeTimeout(TimeValue.timeValueSeconds(60))
1146+
.setClusterManagerNodeTimeout(TimeValue.timeValueSeconds(60))
11471147
.get();
11481148

11491149
} catch (Exception ignored) {}

server/src/main/java/org/opensearch/action/search/TransportSearchScrollAction.java

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,9 @@
3939
import org.opensearch.core.action.ActionListener;
4040
import org.opensearch.core.common.io.stream.Writeable;
4141
import org.opensearch.tasks.Task;
42+
import org.opensearch.threadpool.ThreadPool;
4243
import org.opensearch.transport.TransportService;
44+
import org.opensearch.wlm.QueryGroupTask;
4345

4446
/**
4547
* Perform the search scroll
@@ -51,24 +53,32 @@ public class TransportSearchScrollAction extends HandledTransportAction<SearchSc
5153
private final ClusterService clusterService;
5254
private final SearchTransportService searchTransportService;
5355
private final SearchPhaseController searchPhaseController;
56+
private final ThreadPool threadPool;
5457

5558
@Inject
5659
public TransportSearchScrollAction(
5760
TransportService transportService,
5861
ClusterService clusterService,
5962
ActionFilters actionFilters,
6063
SearchTransportService searchTransportService,
61-
SearchPhaseController searchPhaseController
64+
SearchPhaseController searchPhaseController,
65+
ThreadPool threadPool
6266
) {
6367
super(SearchScrollAction.NAME, transportService, actionFilters, (Writeable.Reader<SearchScrollRequest>) SearchScrollRequest::new);
6468
this.clusterService = clusterService;
6569
this.searchTransportService = searchTransportService;
6670
this.searchPhaseController = searchPhaseController;
71+
this.threadPool = threadPool;
6772
}
6873

6974
@Override
7075
protected void doExecute(Task task, SearchScrollRequest request, ActionListener<SearchResponse> listener) {
7176
try {
77+
78+
if (task instanceof QueryGroupTask) {
79+
((QueryGroupTask) task).setQueryGroupId(threadPool.getThreadContext());
80+
}
81+
7282
ParsedScrollId scrollId = TransportSearchHelper.parseScrollId(request.scrollId());
7383
Runnable action;
7484
switch (scrollId.getType()) {

server/src/main/java/org/opensearch/action/support/clustermanager/ClusterManagerNodeOperationRequestBuilder.java

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -63,17 +63,6 @@ public final RequestBuilder setClusterManagerNodeTimeout(TimeValue timeout) {
6363
return (RequestBuilder) this;
6464
}
6565

66-
/**
67-
* Sets the cluster-manager node timeout in case the cluster-manager has not yet been discovered.
68-
*
69-
* @deprecated As of 2.1, because supporting inclusive language, replaced by {@link #setClusterManagerNodeTimeout(TimeValue)}
70-
*/
71-
@SuppressWarnings("unchecked")
72-
@Deprecated
73-
public final RequestBuilder setMasterNodeTimeout(TimeValue timeout) {
74-
return setClusterManagerNodeTimeout(timeout);
75-
}
76-
7766
/**
7867
* Sets the cluster-manager node timeout in case the cluster-manager has not yet been discovered.
7968
*/
@@ -82,15 +71,4 @@ public final RequestBuilder setClusterManagerNodeTimeout(String timeout) {
8271
request.clusterManagerNodeTimeout(timeout);
8372
return (RequestBuilder) this;
8473
}
85-
86-
/**
87-
* Sets the cluster-manager node timeout in case the cluster-manager has not yet been discovered.
88-
*
89-
* @deprecated As of 2.1, because supporting inclusive language, replaced by {@link #setClusterManagerNodeTimeout(String)}
90-
*/
91-
@SuppressWarnings("unchecked")
92-
@Deprecated
93-
public final RequestBuilder setMasterNodeTimeout(String timeout) {
94-
return setClusterManagerNodeTimeout(timeout);
95-
}
9674
}

server/src/main/java/org/opensearch/cluster/LocalNodeMasterListener.java

Lines changed: 0 additions & 76 deletions
This file was deleted.

server/src/main/java/org/opensearch/cluster/MasterNodeChangePredicate.java

Lines changed: 0 additions & 53 deletions
This file was deleted.

server/src/main/java/org/opensearch/cluster/NotMasterException.java

Lines changed: 0 additions & 57 deletions
This file was deleted.

server/src/main/java/org/opensearch/cluster/coordination/NoMasterBlockService.java

Lines changed: 0 additions & 50 deletions
This file was deleted.

server/src/main/java/org/opensearch/cluster/coordination/UnsafeBootstrapMasterCommand.java

Lines changed: 0 additions & 47 deletions
This file was deleted.

0 commit comments

Comments
 (0)