Skip to content

Commit 0a36e93

Browse files
committed
Fix incorrect logging in stats API parameter parsing
Signed-off-by: Andy Qin <[email protected]>
1 parent d42efb1 commit 0a36e93

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

src/main/java/org/opensearch/neuralsearch/rest/RestNeuralStatsAction.java

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import org.opensearch.rest.action.RestActions;
2222
import org.opensearch.transport.client.node.NodeClient;
2323

24+
import java.util.ArrayList;
2425
import java.util.Arrays;
2526
import java.util.EnumSet;
2627
import java.util.List;
@@ -179,12 +180,13 @@ private NeuralStatsInput createNeuralStatsInputFromRequestParams(RestRequest req
179180

180181
private boolean processRequestedStats(String[] stats, NeuralStatsInput neuralStatsInput) {
181182
boolean statAdded = false;
183+
List<String> invalidStatNames = new ArrayList<>();
182184

183185
for (String stat : stats) {
184186
// Validate parameter
185187
String normalizedStat = stat.toLowerCase(Locale.ROOT);
186188
if (isValidParamString(normalizedStat) == false) {
187-
log.info("Invalid stat name parameter format: {}", normalizedStat);
189+
invalidStatNames.add(normalizedStat);
188190
continue;
189191
}
190192

@@ -194,9 +196,14 @@ private boolean processRequestedStats(String[] stats, NeuralStatsInput neuralSta
194196
} else if (STATE_STAT_NAMES.contains(normalizedStat)) {
195197
neuralStatsInput.getInfoStatNames().add(InfoStatName.from(normalizedStat));
196198
statAdded = true;
199+
} else {
200+
invalidStatNames.add(normalizedStat);
197201
}
198-
log.info("Non-existent stat name parsed: {}", normalizedStat);
199202
}
203+
if (invalidStatNames.isEmpty() == false) {
204+
log.info("Invalid stat names in neural stats request: {}", invalidStatNames);
205+
}
206+
200207
return statAdded;
201208
}
202209

0 commit comments

Comments
 (0)