Integration test fix

Author: rhamilto

frontend/packages/integration-tests-cypress/tests/app/start-job-from-cronjob.cy.ts

@@ -68,7 +68,7 @@ describe('Start a Job from a CronJob', () => {
     cy.visit(`/k8s/ns/${testName}/cronjobs`);
     listPage.rows.shouldBeLoaded();
     cy.visit(`/k8s/ns/${testName}/cronjobs/${CRONJOB_NAME}/jobs`);
-    listPage.rows.countShouldBe(2);
+    listPage.dvRows.countShouldBe(2);
   });
 
   it('verify the number of events in CronJob > Events tab list page', () => {

frontend/packages/integration-tests-cypress/tests/crud/resource-crud.cy.ts

@@ -106,6 +106,15 @@ describe('Kubernetes resource CRUD operations', () => {
     'BuildConfig',
   ]);
 
+  const dataViewResources = new Set([
+    'HorizontalPodAutoscaler',
+    'Job',
+    'Pod',
+    'ReplicaSet',
+    'ReplicationController',
+    'StatefulSet',
+  ]);
+
   testObjs.forEach((testObj, resource) => {
     const {
       kind,
@@ -120,6 +129,7 @@ describe('Kubernetes resource CRUD operations', () => {
     }
     describe(kind, () => {
       const name = `${testName}-${_.kebabCase(kind)}`;
+      const isDataViewResource = dataViewResources.has(kind);
 
       it(`creates the resource instance`, () => {
         cy.visit(
@@ -189,6 +199,8 @@ describe('Kubernetes resource CRUD operations', () => {
             cy.byTestID('yaml-error').should('not.exist');
           });
         });
+        detailsPage.isLoaded();
+        detailsPage.titleShouldContain(name);
       });
 
       it('displays detail view for newly created resource instance', () => {
@@ -215,7 +227,11 @@ describe('Kubernetes resource CRUD operations', () => {
           // should not have a namespace dropdown for non-namespaced objects');
           projectDropdown.shouldNotExist();
         }
-        listPage.rows.shouldBeLoaded();
+        if (isDataViewResource) {
+          listPage.dvRows.shouldBeLoaded();
+        } else {
+          listPage.rows.shouldBeLoaded();
+        }
         cy.testA11y(`List page for ${kind}: ${name}`);
         cy.testI18n([ListPageSelector.tableColumnHeaders], ['item-create']);
       });
@@ -227,7 +243,11 @@ describe('Kubernetes resource CRUD operations', () => {
           }?kind=${kind}&q=${testLabel}%3d${testName}&name=${name}`,
         );
 
-        listPage.rows.shouldExist(name);
+        if (isDataViewResource) {
+          listPage.dvRows.shouldExist(name);
+        } else {
+          listPage.rows.shouldExist(name);
+        }
         cy.testA11y(`Search page for ${kind}: ${name}`);
 
         // link to to details page
@@ -242,7 +262,11 @@ describe('Kubernetes resource CRUD operations', () => {
             namespaced ? `ns/${testName}` : 'all-namespaces'
           }?kind=${kind}&q=${testLabel}%3d${testName}&name=${name}`,
         );
-        listPage.rows.clickKebabAction(name, editKind(kind, humanizeKind));
+        if (isDataViewResource) {
+          listPage.dvRows.clickKebabAction(name, editKind(kind, humanizeKind));
+        } else {
+          listPage.rows.clickKebabAction(name, editKind(kind, humanizeKind));
+        }
         if (!skipYamlReloadTest) {
           yamlEditor.isLoaded();
           yamlEditor.clickReloadButton();
@@ -254,9 +278,15 @@ describe('Kubernetes resource CRUD operations', () => {
 
       it(`deletes the resource instance`, () => {
         cy.visit(`${namespaced ? `/k8s/ns/${testName}` : '/k8s/cluster'}/${resource}`);
-        listPage.filter.byName(name);
-        listPage.rows.countShouldBe(1);
-        listPage.rows.clickKebabAction(name, deleteKind(kind, humanizeKind));
+        if (isDataViewResource) {
+          listPage.dvFilter.byName(name);
+          listPage.dvRows.countShouldBe(1);
+          listPage.dvRows.clickKebabAction(name, deleteKind(kind, humanizeKind));
+        } else {
+          listPage.filter.byName(name);
+          listPage.rows.countShouldBe(1);
+          listPage.rows.clickKebabAction(name, deleteKind(kind, humanizeKind));
+        }
         modal.shouldBeOpened();
         modal.submit();
         modal.shouldBeClosed();

frontend/packages/integration-tests-cypress/views/list-page.ts

@@ -56,6 +56,16 @@ export const listPage = {
       cy.get('@filterDropdownToggleButton').click();
     },
   },
+  dvFilter: {
+    byName: (name: string) => {
+      // these are not great selectors, but we're limited by data view toolbar
+      cy.get('[data-ouia-component-id="DataViewToolbar"').within(() =>
+        cy.get('.pf-v6-c-menu-toggle').first().click(),
+      );
+      cy.get('.pf-v6-c-menu__list-item').contains('Name').click();
+      cy.get('[aria-label="Name filter"]').clear().type(name);
+    },
+  },
   rows: {
     getFirstElementName: () => cy.get('[data-test-rows="resource-row"] a').first(),
     shouldBeLoaded: () => {
@@ -113,6 +123,14 @@ export const listPage = {
         });
       cy.byTestActionID(actionName).click();
     },
+    shouldExist: (resourceName: string) => {
+      cy.get(`[data-test="data-view-cell-${resourceName}-name"]`)
+        .contains(resourceName)
+        .should('exist');
+    },
+    countShouldBe: (count: number) => {
+      cy.get(`[data-test^="data-view-cell-"]`).should('have.length', count);
+    },
   },
 };