Skip to content

Commit e305329

Browse files
Merge pull request #14872 from vojtechszocs/apply-api-label-to-plugin-sdk-shared-modules
OCPBUGS-53103: Apply plugin-api-changed label to plugin SDK shared modules
2 parents 2689ddf + a497123 commit e305329

File tree

8 files changed

+16
-8
lines changed

8 files changed

+16
-8
lines changed

frontend/packages/console-dynamic-plugin-sdk/scripts/package-definitions.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@ import * as fs from 'fs-extra';
33
import * as glob from 'glob';
44
import * as _ from 'lodash';
55
import * as readPkg from 'read-pkg';
6-
import { sharedPluginModules, getSharedModuleMetadata } from '../src/shared-modules';
6+
import {
7+
sharedPluginModules,
8+
getSharedModuleMetadata,
9+
} from '../src/shared-modules/shared-modules-meta';
710
import { resolvePath } from './utils/path';
811

912
type GeneratedPackage = {

frontend/packages/console-dynamic-plugin-sdk/src/runtime/plugin-loader.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {
1010
isStandardPluginManifest,
1111
} from '../build-types';
1212
import { resolveEncodedCodeRefs } from '../coderefs/coderef-resolver';
13-
import { initSharedPluginModules } from '../shared-modules-init';
13+
import { initSharedPluginModules } from '../shared-modules/shared-modules-init';
1414
import { RemoteEntryModule } from '../types';
1515
import { ErrorWithCause } from '../utils/error/custom-error';
1616
import { settleAllPromises } from '../utils/promise';
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
labels:
2+
- plugin-api-changed

frontend/packages/console-dynamic-plugin-sdk/src/__tests__/shared-modules-init.spec.ts renamed to frontend/packages/console-dynamic-plugin-sdk/src/shared-modules/__tests__/shared-modules-init.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import { sharedPluginModules } from '../shared-modules';
1+
import { getEntryModuleMocks } from '../../utils/test-utils';
22
import { initSharedPluginModules } from '../shared-modules-init';
3-
import { getEntryModuleMocks } from '../utils/test-utils';
3+
import { sharedPluginModules } from '../shared-modules-meta';
44

55
describe('initSharedPluginModules', () => {
66
it('is consistent with sharedPluginModules definition', () => {

frontend/packages/console-dynamic-plugin-sdk/src/shared-modules-init.ts renamed to frontend/packages/console-dynamic-plugin-sdk/src/shared-modules/shared-modules-init.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
/* eslint-disable global-require */
22
/* eslint-disable @typescript-eslint/no-require-imports */
33

4-
import { SharedModuleNames } from './shared-modules';
5-
import { RemoteEntryModule } from './types';
4+
import { RemoteEntryModule } from '../types';
5+
import { SharedModuleNames } from './shared-modules-meta';
66

77
type SharedScopeObject = {
88
[moduleName: string]: {
File renamed without changes.

frontend/packages/console-dynamic-plugin-sdk/src/webpack/ConsoleRemotePlugin.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,10 @@ import * as semver from 'semver';
1313
import * as webpack from 'webpack';
1414
import { ConsolePluginBuildMetadata, ConsolePluginPackageJSON } from '../build-types';
1515
import { extensionsFile } from '../constants';
16-
import { sharedPluginModules, getSharedModuleMetadata } from '../shared-modules';
16+
import {
17+
sharedPluginModules,
18+
getSharedModuleMetadata,
19+
} from '../shared-modules/shared-modules-meta';
1720
import { DynamicModuleMap, getDynamicModuleMap } from '../utils/dynamic-module-parser';
1821
import { parseJSONC } from '../utils/jsonc';
1922
import { loadSchema } from '../utils/schema';

frontend/webpack.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import * as MiniCssExtractPlugin from 'mini-css-extract-plugin';
66
import * as path from 'path';
77
import * as webpack from 'webpack';
88

9-
import { sharedPluginModules } from '@console/dynamic-plugin-sdk/src/shared-modules';
9+
import { sharedPluginModules } from '@console/dynamic-plugin-sdk/src/shared-modules/shared-modules-meta';
1010
import { ExtensionValidatorPlugin } from '@console/dynamic-plugin-sdk/src/webpack/ExtensionValidatorPlugin';
1111
import { resolvePluginPackages } from '@console/plugin-sdk/src/codegen/plugin-resolver';
1212
import { HtmlWebpackSkipAssetsPlugin } from 'html-webpack-skip-assets-plugin';

0 commit comments

Comments
 (0)