Skip to content

Remove xrefs from modules #41954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bergerhoffer opened this issue Feb 15, 2022 · 13 comments
Open

Remove xrefs from modules #41954

bergerhoffer opened this issue Feb 15, 2022 · 13 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@bergerhoffer
Copy link
Contributor

In reviewing a module, I noticed that there was an xref in it. A quick search of the modules/ directory showed quite a few in there.

We currently don't allow xrefs in modules per our guidelines. We should do a sweep and remove these xrefs. (Comment out or otherwise leave a note so that they can be found/added back in later, if/when we do allow them again).

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 17, 2022
@bergerhoffer
Copy link
Contributor Author

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 25, 2022
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 24, 2022
@bergerhoffer
Copy link
Contributor Author

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 24, 2022
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 23, 2022
@bergerhoffer
Copy link
Contributor Author

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 23, 2022
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 22, 2023
@bergerhoffer
Copy link
Contributor Author

/lifecycle frozen

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 22, 2023
@bergerhoffer
Copy link
Contributor Author

/remove-lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Feb 22, 2023
@peterroth
Copy link
Contributor

peterroth commented Feb 28, 2024

Is this still a valid ticket, @bergerhoffer?
If so, could you please enlighten me if only the xrefs needs to be removed or they should be handled an other way?

@bergerhoffer
Copy link
Contributor Author

@peterroth yes it is still valid, but unfortunately is not a quick/easy fix. They don't need to just be removed, they will each need to be evaluated and see if we need to add them in as a workaround elsewhere. I think we likely have a few hundred :/

@peterroth
Copy link
Contributor

I see, @bergerhoffer. In this case I can't fix the ticket because I don't have the reliable resource to build and test the changes.

@bergerhoffer
Copy link
Contributor Author

I see, @bergerhoffer. In this case I can't fix the ticket because I don't have the reliable resource to build and test the changes.

Agreed. This one will likely need to be done by our team, and likely broken up for several writers to do.

There are likely other tickets that are more suited for anyone to pick up, if you're looking to contribute more. Let me know if you need any help finding something, if you are!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

3 participants