Skip to content

Commit 0d05b6a

Browse files
committed
Add exceptions for the violating COs
The bugs are created for the case of node rebooting. The condition goes to Progressing=True with the same reason that we found for the cluster scaling up/down. Thus, we re-use the bugs instead of recreating a new set of bugs that might be closed as duplciates.
1 parent 8756d70 commit 0d05b6a

File tree

1 file changed

+25
-0
lines changed

1 file changed

+25
-0
lines changed

test/extended/machines/scale.go

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -237,16 +237,41 @@ var _ = g.Describe("[sig-cluster-lifecycle][Feature:Machines][Serial] Managed cl
237237
g.AfterEach(func() {
238238
helper.DeleteAllExtraWorkers()
239239

240+
except := func(co string) string {
241+
switch co {
242+
case "dns":
243+
return "https://issues.redhat.com/browse/OCPBUGS-62623"
244+
case "image-registry":
245+
return "https://issues.redhat.com/browse/OCPBUGS-62626"
246+
case "network":
247+
return "https://issues.redhat.com/browse/OCPBUGS-62630"
248+
case "node-tuning":
249+
return "https://issues.redhat.com/browse/OCPBUGS-62632"
250+
case "storage":
251+
return "https://issues.redhat.com/browse/OCPBUGS-62633"
252+
default:
253+
return ""
254+
}
255+
}
256+
240257
// No cluster operator should leave Progressing=False only up to cluster scaling
241258
// https://github.com/openshift/api/blob/61248d910ff74aef020492922d14e6dadaba598b/config/v1/types_cluster_operator.go#L163-L164
242259
operatorsNotProgressingAfter := getOperatorsNotProgressing(configClient)
243260
var violations []string
261+
exceptions := map[string]string{}
244262
for operator, t1 := range operatorsNotProgressing {
245263
t2, ok := operatorsNotProgressingAfter[operator]
246264
if !ok || t1.Unix() != t2.Unix() {
265+
if reason := except(operator); reason != "" {
266+
exceptions[operator] = reason
267+
continue
268+
}
247269
violations = append(violations, operator)
248270
}
249271
}
272+
if len(exceptions) > 0 {
273+
e2e.Logf("those cluster operators left Progressing=False while cluster was scaling for a reason: %v", exceptions)
274+
}
250275
o.Expect(violations).To(o.BeEmpty(), "those cluster operators left Progressing=False while cluster was scaling: %v", violations)
251276
})
252277

0 commit comments

Comments
 (0)