Skip to content

Commit 6e43bdc

Browse files
committed
Add exceptions for the violating COs
The bugs are created for the case of node rebooting. The condition goes to Progressing=True with the same reason that we found for the cluster scaling up/down. Thus, we re-use the bugs instead of recreating a new set of bugs that might be closed as duplciates.
1 parent 787e9be commit 6e43bdc

File tree

1 file changed

+16
-9
lines changed

1 file changed

+16
-9
lines changed

test/extended/machines/scale.go

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -239,16 +239,16 @@ var _ = g.Describe("[sig-cluster-lifecycle][Feature:Machines][Serial] Managed cl
239239

240240
except := func(co string) string {
241241
switch co {
242-
case "network":
243-
return "https://issues.redhat.com/browse/OCPBUGS-TODO"
242+
case "dns":
243+
return "https://issues.redhat.com/browse/OCPBUGS-62623"
244244
case "image-registry":
245-
return "https://issues.redhat.com/browse/OCPBUGS-TODO"
245+
return "https://issues.redhat.com/browse/OCPBUGS-62626"
246+
case "network":
247+
return "https://issues.redhat.com/browse/OCPBUGS-62630"
246248
case "node-tuning":
247-
return "https://issues.redhat.com/browse/OCPBUGS-TODO"
249+
return "https://issues.redhat.com/browse/OCPBUGS-62632"
248250
case "storage":
249-
return "https://issues.redhat.com/browse/OCPBUGS-TODO"
250-
case "dns":
251-
return "https://issues.redhat.com/browse/OCPBUGS-TODO"
251+
return "https://issues.redhat.com/browse/OCPBUGS-62633"
252252
default:
253253
return ""
254254
}
@@ -258,13 +258,20 @@ var _ = g.Describe("[sig-cluster-lifecycle][Feature:Machines][Serial] Managed cl
258258
// https://github.com/openshift/api/blob/61248d910ff74aef020492922d14e6dadaba598b/config/v1/types_cluster_operator.go#L163-L164
259259
operatorsNotProgressingAfter := getOperatorsNotProgressing(configClient)
260260
var violations []string
261+
exceptions := map[string]string{}
261262
for operator, t1 := range operatorsNotProgressing {
262263
t2, ok := operatorsNotProgressingAfter[operator]
263-
if reason := except(operator); reason == "" && (!ok || t1.Unix() != t2.Unix()) {
264+
if !ok || t1.Unix() != t2.Unix() {
265+
if reason := except(operator); reason != "" {
266+
exceptions[operator] = reason
267+
continue
268+
}
264269
violations = append(violations, operator)
265270
}
266271
}
267-
272+
if len(exceptions) > 0 {
273+
e2e.Logf("those cluster operators left Progressing=False while cluster was scaling for a reason: %v", exceptions)
274+
}
268275
o.Expect(violations).To(o.BeEmpty(), "those cluster operators left Progressing=False while cluster was scaling: %v", violations)
269276
})
270277

0 commit comments

Comments
 (0)