ovn-k, virt, preconfigured-udn-addrs: Test MAC conflict detection

Verify KubeVirt VMs with preconfigured MAC address retain a
requested MAC address before and after another VM is created
requesting the same MAC address.
And verify the other VM requesting the same MAC address get
the appropriate address conflict error event.

Signed-off-by: Or Mergi <[email protected]>

Author: ormergi

test/extended/networking/livemigration.go

@@ -328,6 +328,20 @@ var _ = Describe("[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][F
 								preconfiguredIPs: []string{"203.203.0.100", "2014:100:200::100"},
 							},
 						),
+						Entry(
+							"[OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured MAC address is created when the address is already taken",
+							networkAttachmentConfigParams{
+								name:               nadName,
+								topology:           "layer2",
+								role:               "primary",
+								allowPersistentIPs: true,
+							},
+							kubevirt.FedoraVMWithPreconfiguredPrimaryUDNAttachment,
+							duplicateVM,
+							workloadNetworkConfig{
+								preconfiguredMAC: "aa:bb:cc:dd:ee:ff",
+							},
+						),
 					)
 				},
 				Entry("NetworkAttachmentDefinitions", func(c networkAttachmentConfigParams) networkAttachmentConfig {
@@ -586,6 +600,21 @@ func duplicateVM(cli *kubevirt.Client, vmNamespace, vmName string) {
 			)
 		})
 	}
+
+	mac, err := cli.GetJSONPath("vmi", vmName, "{.spec.domain.devices.interfaces[0].macAddress}")
+	Expect(err).NotTo(HaveOccurred())
+	if len(mac) > 0 {
+		vmiExpectations = append(vmiExpectations, func() {
+			waitForVMPodEventWithMessage(
+				cli,
+				vmNamespace,
+				duplicateVMName,
+				"MAC address already in use",
+				2*time.Minute,
+			)
+		})
+	}
+
 	Expect(cli.CreateVMIFromSpec(vmNamespace, duplicateVMName, vmiSpec, vmiCreationOptions...)).To(Succeed())
 	for _, expectation := range vmiExpectations {
 		expectation()

test/extended/util/annotate/generated/zz_generated.annotations.go

@@ -972,6 +972,12 @@ spec:
         UserDefinedNetwork [Suite:openshift/network/virtualization] should keep ip
         [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured
         IPs attached to a primary UDN is restarted'
+    - testName: '[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration]
+        Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined
+        networks and persistent ips configured created using [OCPFeatureGate:NetworkSegmentation]
+        UserDefinedNetwork [Suite:openshift/network/virtualization] should keep ip
+        [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured
+        MAC address is created when the address is already taken'
     - testName: '[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration]
         Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined
         networks and persistent ips configured created using [OCPFeatureGate:NetworkSegmentation]
@@ -1026,6 +1032,12 @@ spec:
         networks and persistent ips configured created using NetworkAttachmentDefinitions
         [Suite:openshift/network/virtualization] should keep ip [OCPFeatureGate:PreconfiguredUDNAddresses]
         when the VM with preconfigured IPs attached to a primary UDN is restarted'
+    - testName: '[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration]
+        Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined
+        networks and persistent ips configured created using NetworkAttachmentDefinitions
+        [Suite:openshift/network/virtualization] should keep ip [OCPFeatureGate:PreconfiguredUDNAddresses]
+        when the VM with preconfigured MAC address is created when the address is
+        already taken'
     - testName: '[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration]
         Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined
         networks and persistent ips configured created using NetworkAttachmentDefinitions
@@ -1076,6 +1088,12 @@ spec:
         UserDefinedNetwork [Suite:openshift/network/virtualization] should keep ip
         [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured
         IPs attached to a primary UDN is restarted'
+    - testName: '[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration]
+        Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined
+        networks and persistent ips configured created using [OCPFeatureGate:NetworkSegmentation]
+        UserDefinedNetwork [Suite:openshift/network/virtualization] should keep ip
+        [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured
+        MAC address is created when the address is already taken'
     - testName: '[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration]
         Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined
         networks and persistent ips configured created using [OCPFeatureGate:NetworkSegmentation]
@@ -1159,6 +1177,12 @@ spec:
         UserDefinedNetwork [Suite:openshift/network/virtualization] should keep ip
         [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured
         IPs attached to a primary UDN is restarted'
+    - testName: '[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration]
+        Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined
+        networks and persistent ips configured created using [OCPFeatureGate:NetworkSegmentation]
+        UserDefinedNetwork [Suite:openshift/network/virtualization] should keep ip
+        [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured
+        MAC address is created when the address is already taken'
     - testName: '[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration]
         Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined
         networks and persistent ips configured created using [OCPFeatureGate:NetworkSegmentation]