revert: prepareEventSources should return map of EventSources

Author: metacosm

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/EventSourceInitializer.java

@@ -21,6 +21,6 @@ public interface EventSourceInitializer<P extends HasMetadata> {
    *        sources
    * @return a map of event sources to register
    */
-  Map<String, ? extends EventSource> prepareEventSources(EventSourceContext<P> context);
+  Map<String, EventSource> prepareEventSources(EventSourceContext<P> context);
 
 }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/Controller.java

@@ -190,7 +190,7 @@ public String successTypeName(UpdateControl<P> result) {
           public UpdateControl<P> execute() throws Exception {
             initContextIfNeeded(resource, context);
             final var exceptions = new ArrayList<Exception>(dependents.size());
-            dependents.values().forEach((name, dependent) -> {
+            dependents.forEach((name, dependent) -> {
               try {
                 final var reconcileResult = dependent.reconcile(resource, context);
                 context.managedDependentResourceContext().setReconcileResult(name, reconcileResult);

sample-operators/webpage/src/main/java/io/javaoperatorsdk/operator/sample/WebPageStandaloneDependentsReconciler.java

@@ -1,6 +1,8 @@
 package io.javaoperatorsdk.operator.sample;
 
 import java.util.Map;
+import java.util.Map.Entry;
+import java.util.stream.Collectors;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -51,10 +53,9 @@ public WebPageStandaloneDependentsReconciler(KubernetesClient kubernetesClient)
   }
 
   @Override
-  public Map<String, ? extends EventSource> prepareEventSources(
-      EventSourceContext<WebPage> context) {
-    dependentResources.values().forEach(dr -> dr.initEventSource(context));
-    return dependentResources;
+  public Map<String, EventSource> prepareEventSources(EventSourceContext<WebPage> context) {
+    return dependentResources.entrySet().stream()
+        .collect(Collectors.toUnmodifiableMap(Entry::getKey, Entry::getValue));
   }
 
   @Override