Skip to content

Commit 5cefd44

Browse files
committed
refactor: improve error reporting, remove redundant logging
1 parent 6eb1890 commit 5cefd44

File tree

1 file changed

+7
-5
lines changed
  • operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing

1 file changed

+7
-5
lines changed

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/Controller.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import java.util.HashMap;
66
import java.util.Map;
77
import java.util.Optional;
8+
import java.util.stream.Collectors;
89

910
import org.slf4j.Logger;
1011
import org.slf4j.LoggerFactory;
@@ -196,15 +197,16 @@ public UpdateControl<P> execute() throws Exception {
196197
log.info("Reconciled dependent '{}' -> {}", name, reconcileResult.getOperation());
197198
} catch (Exception e) {
198199
final var message = e.getMessage();
199-
exceptions.add(new ManagedDependentResourceException(name,
200-
"Couldn't reconcile DependentResource named: " + name + ", cause: " + message,
201-
e));
202-
log.warn("Error reconciling dependent '{}': {}", name, message);
200+
exceptions.add(new ManagedDependentResourceException(
201+
name, "Error reconciling dependent '" + name + "': " + message, e));
203202
}
204203
});
205204

206205
if (!exceptions.isEmpty()) {
207-
throw new AggregatedOperatorException("One or more DependentResource(s) failed",
206+
throw new AggregatedOperatorException("One or more DependentResource(s) failed:\n" +
207+
exceptions.stream()
208+
.map(e -> "\t\t- " + e.getMessage())
209+
.collect(Collectors.joining("\n")),
208210
exceptions);
209211
}
210212

0 commit comments

Comments
 (0)