You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ResourceController's main entry point is createOrUpdateResource(R resource, Context<R> context) seems misleading as in fact the method operates on an already existing CR so not sure if create is actually an option.
Maybe reconcile would be a better name ?
The text was updated successfully, but these errors were encountered:
@lburgazzoli I agree, reaised this actually too. The original idea was that we create or update resources managed by the controller so it's meant like that (not creating or updating the CR). Or in event context handle createOrUpdate even of a custom resource. However we are currently also support different events from differnet events sources, so this naming does not fit at all IMHO. So the correct name should be reconcile.
In addition to that also the delete method should be rather cleanup.
ResourceController
's main entry point iscreateOrUpdateResource(R resource, Context<R> context)
seems misleading as in fact the method operates on an already existing CR so not sure ifcreate
is actually an option.Maybe
reconcile
would be a better name ?The text was updated successfully, but these errors were encountered: