Skip to content

Access to CustomResourceCache #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shawkins opened this issue Mar 26, 2021 · 2 comments
Open

Access to CustomResourceCache #390

shawkins opened this issue Mar 26, 2021 · 2 comments
Assignees
Labels
feature kind/feature Categorizes issue or PR as related to a new feature. triage/support Indicates an issue that is a support question.

Comments

@shawkins
Copy link
Collaborator

We are looking to implement metrics over the custom resource managed by the operator and would like to avoid k8s api calls if possible. It seems that the cache could be utilized either directly or indirectly for this purpose. Directly would look like having access in the Controller, possibly via the init method - then we could use that to drive simple metrics count, and checks based upon the resource Status. Indirect access would be related to #323 - such that count and other readily definable metrics are automatically exposed.

@csviri
Copy link
Collaborator

csviri commented Apr 9, 2021

Hi @shawkins , it's an interesting idea, the cache is quite an internal thing, currently we are actually changing the implementation regarding to it. So it will be more extensible and replacable with custom implementation.
However not sure if that is the best place to imeplement metrics. I agree that observability could be better in general.
I think the best would be to implement metrics with micromete, seer: #64

What metrics you are interested in, could you provide some examples? Thx

@shawkins
Copy link
Collaborator Author

I think the best would be to implement metrics with micromete, seer: #64

Yes, that is the approach we are taking with the quarkus + micrometer integration.

What metrics you are interested in, could you provide some examples? Thx

Access to the cache was for things like:

Related to #64 and #323 in general we added Timed and Counted at the primary controller methods - see #393 (which I should have logged against the extension). Those as well could be handled by the operator framework itself.

@metacosm metacosm self-assigned this Apr 16, 2021
@jmrodri jmrodri added kind/feature Categorizes issue or PR as related to a new feature. feature triage/support Indicates an issue that is a support question. labels Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature kind/feature Categorizes issue or PR as related to a new feature. triage/support Indicates an issue that is a support question.
Projects
None yet
Development

No branches or pull requests

4 participants