Skip to content

Update observedGeneration also on UpdateControl.updateResource #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
csviri opened this issue Nov 25, 2021 · 0 comments · Fixed by #731
Closed

Update observedGeneration also on UpdateControl.updateResource #713

csviri opened this issue Nov 25, 2021 · 0 comments · Fixed by #731
Assignees
@csviri
Labels
needs-discussion Issue needs to be discussed more before working on it
Milestone
v2

Comments

@csviri
Copy link
Collaborator

csviri commented Nov 25, 2021 •
edited
Loading

Currently if UpdateControl.updateResource returned from reconciler, the observed generation is not update. However, this would likely (probably always) results in a new reconciliation after the event from the update is received.

On the other hand the generation was observed, and the users intention is to update the resource. So the observed generation should be set.
@csviri csviri added the needs-discussion Issue needs to be discussed more before working on it label Nov 25, 2021
@csviri csviri added this to the v2 milestone Nov 25, 2021
@csviri csviri self-assigned this Nov 25, 2021
@snowdrop-bot snowdrop-bot mentioned this issue Nov 25, 2021
Closed
@csviri csviri linked a pull request Dec 2, 2021 that will close this issue
feature: update observed generation on updateResource #731
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csviri csviri

Labels
needs-discussion Issue needs to be discussed more before working on it
Projects
None yet
Milestone
v2
Development

Successfully merging a pull request may close this issue.

feature: update observed generation on updateResource operator-framework/java-operator-sdk
1 participant
@csviri