Skip to content

Need to review usage of DependentResource.resourceType #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #923
metacosm opened this issue Feb 15, 2022 · 2 comments
Closed
Tracked by #923

Need to review usage of DependentResource.resourceType #939

metacosm opened this issue Feb 15, 2022 · 2 comments
Assignees
@metacosm
Labels
dependent-resources-epic kind/bug Categorizes issue or PR as related to a bug.

Comments

@metacosm
Copy link
Collaborator

metacosm commented Feb 15, 2022 •
edited
Loading

This issue is about being able to resolve the resource type independently of the DependentResource implementation so that it could possibly be resolved at build time instead of runtime. Basically, separate metadata/configuration from the implementation.
@metacosm metacosm mentioned this issue Feb 15, 2022
Closed
13 tasks
@metacosm metacosm self-assigned this Feb 15, 2022
@metacosm metacosm added the kind/bug Categorizes issue or PR as related to a bug. label Feb 15, 2022
@csviri
Copy link
Collaborator

csviri commented Feb 16, 2022

Could you describe this issue? Now this is moved to KubernetesDependentResource where it is detected automatically. But also there is a possibiilty to override it, in case of some multi level hierarchy. Not sure if this is an issue anymore.

@csviri
Copy link
Collaborator

csviri commented Apr 5, 2022

The decision was to have the resourceType on the top level .

@csviri csviri closed this as completed Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metacosm metacosm

Labels
dependent-resources-epic kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@metacosm @csviri